make logsumexp composite compliant #77130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced May 10, 2022
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 5345f09 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
ezyang
approved these changes
May 11, 2022
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
This was referenced May 18, 2022
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
`logsumexp` advertises as `CompositeExplicitAutograd`, so it should go through the dispatcher when calling other ops (`logsumexp.out`). This came up because `logsumexp.out` calls view ops internally (`squeeze()`), so I want to opt it out of LTC/XLA with a new `CompositeExplicitAutogradNonFunctional` alias key). Calling `logsumexp` should then know to not use the native implementation of `logsumexp.out` when running on the LTC/XLA backend. [ghstack-poisoned]
|
@pytorchbot merge |
|
Hey @bdhirsh. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 26, 2022
Summary: Pull Request resolved: #77130 composite Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6185478edbe3b7cb58dd18f7479ef6d0baba031e Reviewed By: mehtanirav Differential Revision: D36668393 Pulled By: bdhirsh fbshipit-source-id: 8623bd11874afcbcea83d5f651bc676562bc970e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logsumexpadvertises asCompositeExplicitAutograd, so it should go through the dispatcher when calling other ops (logsumexp.out).This came up because
logsumexp.outcalls view ops internally (squeeze()), so I want to opt it out of LTC/XLA with a newCompositeExplicitAutogradNonFunctionalalias key). Callinglogsumexpshould then know to not use the native implementation oflogsumexp.outwhen running on the LTC/XLA backend.Stack from ghstack: