8000 [ci] delete old linter stuff by suo · Pull Request #76984 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ci] delete old linter stuff #76984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[ci] delete old linter stuff #76984

wants to merge 5 commits into from

Conversation

suo
Copy link
Member
@suo suo commented May 6, 2022 •
edited
Loading

Stack from ghstack:

lintrunner has been running for a while, so delete redundant linter
things

@suo
[ci] delete old linter stuff
1178ed3 
lintrunner has been running for a while, so delete redundant linter
things

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented May 6, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 0a66684 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

suo added a commit that referenced this pull request May 6, 2022
@suo
[ci] delete old linter stuff
97e29f3 
lintrunner has been running for a while, so delete redundant linter
things

ghstack-source-id: 2ec6ade
Pull Request resolved: #76984
@suo
Copy link
Member Author
suo commented May 6, 2022

@pytorchbot rebase this

@pytorchmergebot
Copy link
Collaborator

PR #76984 is a ghstack, which is currently not supported

@suo
Update on "[ci] delete old linter stuff"
7d63e37 
lintrunner has been running for a while, so delete redundant linter
things

[ghstack-poisoned]
suo added a commit that referenced this pull request May 9, 2022
@suo
[ci] delete old linter stuff
fb1bf30 
lintrunner has been running for a while, so delete redundant linter
things

ghstack-source-id: 8f35f13
Pull Request resolved: #76984
@suo suo requested a review from janeyx99 May 10, 2022 21:13
@suo
Copy link
Member Author
suo commented May 10, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @suo.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@janeyx99
Copy link
Contributor

@pytorchbot revert this please as it broke lint on trunk

pytorchmergebot added a commit that referenced this pull request May 10, 2022
@pytorchmergebot
Revert "[ci] delete old linter stuff"
12f67ed 
This reverts commit 3a68155.

Reverted #76984 on behalf of https://github.com/janeyx99
@suo suo reopened this May 11, 2022
@suo
Update on "[ci] delete old linter stuff"
e502007 
lintrunner has been running for a while, so delete redundant linter
things

[ghstack-poisoned]
@suo
Update on "[ci] delete old linter stuff"
fdfada4 
lintrunner has been running for a while, so delete redundant linter
things

[ghstack-poisoned]
@suo
Update on "[ci] delete old linter stuff"
0a66684 
lintrunner has been running for a while, so delete redundant linter
things

[ghstack-poisoned]
suo added a commit that referenced this pull request May 11, 2022
@suo
[ci] delete old linter stuff
bc91a8e 
lintrunner has been running for a while, so delete redundant linter
things

ghstack-source-id: 4b5d0cb
Pull Request resolved: #76984
@suo
Copy link
Member Author
suo commented May 11, 2022

@pytorchbot merge this on green

@github-actions
Copy link
Contributor

Hey @suo.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 13, 2022
@suo @facebook-github-bot
[ci] delete old linter stuff (#76984)
a6afd4b 
Summary:
lintrunner has been running for a while, so delete redundant linter
things

Pull Request resolved: #76984

Approved by: https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/3a68155ce0973c005457593375801a2cc19de54f

Reviewed By: atalman

Differential Revision: D36322161

Pulled By: suo

fbshipit-source-id: 5633b8cdbee69649ede62f415e8e510e72ccca9b
facebook-github-bot pushed a commit that referenced this pull request May 13, 2022
@pytorchmergebot @facebook-github-bot
Revert "[ci] delete old linter stuff"
a230139 
Summary:
This reverts commit 3a68155.

Reverted #76984 on behalf of https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/12f67ed2c0dd4ee0434595418668f93a14a4cee9

Reviewed By: atalman

Differential Revision: D36322204

Pulled By: malfet

fbshipit-source-id: 65cb2c4882df5f3b831bf14de225756fa1a3228d
facebook-github-bot pushed a commit that referenced this pull request May 13, 2022
@suo @facebook-github-bot
[ci] delete old linter stuff (#76984)
b1ddc0b 
Summary:
lintrunner has been running for a while, so delete redundant linter
things

Pull Request resolved: #76984

Approved by: https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6cbe9d1f58fdc9288833b8d82db6896af0e4555f

Reviewed By: atalman

Differential Revision: D36322398

Pulled By: suo

fbshipit-source-id: b6505af928c9ab4d0c6679c6de5eb07f45867b3e
@facebook-github-bot facebook-github-bot deleted the gh/suo/517/head branch May 14, 2022 14:18
@janeyx99 janeyx99 mentioned this pull request May 18, 2022
Closed
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees
No one assigned
Labels
cla signed Merged Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suo @facebook-github-bot @pytorchmergebot @janeyx99
0