-
Notifications
You must be signed in to change notification settings - Fork 24.4k
fix: buck2 build fbcode//caffe2:torch_types_gen #75176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: Switch to python resources to fix build on buck2 https://www.internalfb.com/intern/wiki/Buck-users/Python_Resources_in_fbcode/ Reviewed By: r-barnes Differential Revision: D35352705 fbshipit-source-id: dd2fb5935fab3ef42c569c1b93cbba831853e8de
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit efe3b14 (more details on the Dr. CI page):
🕵️ 15 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This pull request was exported from Phabricator. Differential Revision: D35352705 |
Summary: Pull Request resolved: #75176 Switch to python resources to fix build on buck2 https://www.internalfb.com/intern/wiki/Buck-users/Python_Resources_in_fbcode/ Reviewed By: r-barnes Differential Revision: D35352705 fbshipit-source-id: f85043ebbcfbb30d287c802ff7401c89155a024a
Hey @luciang. |
@@ -11,6 +11,7 @@ | |||
from typing import Sequence, List, Dict | |||
|
|||
from tools.autograd.gen_python_functions import should_generate_py_binding, load_signatures, group_overloads | |||
from libfb.py import parutil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luciang this change adds libfb.py dependency that breaks pytorch build for open-source setups.
What is the origin of libfb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is reverted now.
This pull request has been reverted by 7b506e8. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
1 similar comment
This pull request has been reverted by 7b506e8. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Summary:
Switch to python resources to fix build on buck2
https://www.internalfb.com/intern/wiki/Buck-users/Python_Resources_in_fbcode/
Reviewed By: r-barnes
Differential Revision: D35352705