8000 masked argmin and argmax by george-qi · Pull Request #74525 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

masked argmin and argmax #74525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

masked argmin and argmax #74525

wants to merge 5 commits into from

Conversation

george-qi
Copy link
Contributor
@george-qi george-qi commented Mar 22, 2022 •
edited
Loading

@george-qi
masked argmin and argmax
bbbf7ab 
[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Mar 22, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 063655a (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

george-qi added a commit that referenced this pull request Mar 22, 2022
@george-qi
masked argmin and argmax
5180377 
ghstack-source-id: 1eb2256
Pull Request resolved: #74525
george-qi added a commit that referenced this pull request Mar 22, 2022
@george-qi
masked argmin and argmax
0965b01 
ghstack-source-id: 24b92f5
Pull Request resolved: #74525
george-qi added a commit that referenced this pull request Mar 30, 2022
@george-qi
masked argmin and argmax
e6f9dba 
ghstack-source-id: a3afe52
Pull Request resolved: #74525
george-qi added a commit that referenced this pull request Mar 31, 2022
@george-qi
masked argmin and argmax
7293716 
ghstack-source-id: f943e24
Pull Request resolved: #74525
@cpuhrsch cpuhrsch added the topic: not user facing topic category label Mar 31, 2022
@cpuhrsch
Copy link
Contributor

@pytorchbot merge this

@zengk95
Copy link
Contributor
zengk95 commented Apr 1, 2022

@pytorchbot revert this

pytorchmergebot added a commit that referenced this pull request Apr 1, 2022
@pytorchmergebot
Revert "masked argmin and argmax"
dfce8e2 
This reverts commit cb68777.

Reverted #74525 on behalf of https://github.com/zengk95
@facebook-github-bot facebook-github-bot deleted the gh/george-qi/27/head branch April 4, 2022 14:17
@seemethere
Copy link
Member

@pytorchbot revert this

Can we have a link to failed CI in our revert this message in the future?

@pytorchmergebot
Copy link
Collaborator

Reverting PR 74525 failed due to Command git -C /home/runner/work/pytorch/pytorch revert --no-edit cb687773fba647769143d0c7b051ca41f2b3a55f returned non-zero exit code 1
Auto-merging torch/testing/_internal/common_methods_invocations.py
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

Raised by https://github.com/pytorch/pytorch/actions/runs/2091428887

@zengk95
Copy link
Contributor
zengk95 commented Apr 4, 2022

This was breaking
linux-bionic-rocm4.5-py3.7-distributed
linux-bionic-py3.7-clang9-slow

Link to Commit: https://hud.pytorch.org/pytorch/pytorch/commit/cb687773fba647769143d0c7b051ca41f2b3a55f
image

@seemethere seemethere mentioned this pull request Apr 4, 2022
Closed
@zengk95 zengk95 mentioned this pull request Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

Assignees
No one assigned
Labels
cla signed Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@george-qi @facebook-github-bot @cpuhrsch @zengk95 @seemethere @pytorchmergebot
0