Process inputs and outputs in fx interpreter #74242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ec8af03 (more details on the Dr. CI page):
🕵️ 15 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
This pull request was exported from Phabricator. Differential Revision: D34898108 |
|
This pull request was exported from Phabricator. Differential Revision: D34898108 |
012418f to
eb154f3
Compare
Summary: Pull Request resolved: pytorch#74242 The inputs and outputs of the graph module might be different from the graph inputs and outputs if users are using custom codegen. In interpreter, it runs the graph instead of the generated forward function so it might not work if user provides the inputs to the graph module. To fill the gap, we call `process_inputs` and `process_outputs` inside interpreter. Test Plan: unit test: test_interpreter_with_codegen Reviewed By: Chillee Differential Revision: D34898108 fbshipit-source-id: 447c2817504b415e4c4fe269434b10ee64ea87ca
eb154f3 to
ec8af03
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34898108 |
jamesr66a
reviewed
Mar 22, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
Summary: Pull Request resolved: #74242 The inputs and outputs of the graph module might be different from the graph inputs and outputs if users are using custom codegen. In interpreter, it runs the graph instead of the generated forward function so it might not work if user provides the inputs to the graph module. To fill the gap, we call `process_inputs` and `process_outputs` inside interpreter. Test Plan: unit test: test_interpreter_with_codegen Reviewed By: jamesr66a, Chillee Differential Revision: D34898108 fbshipit-source-id: 250bd236f6c8c1268a363cf19a09521a4f64b3a9
|
Hey @842974287. |
|
Looks like this broke the BC tests on master (didn't run |
|
@pytorchbot revert this |
|
Reverting PR 74242 failed due to 'nodyText' |
|
cc @malfet for error, reverting in phab |
|
This pull request has been reverted by bf5e25f. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
9E88
842974287
added a commit
to 842974287/pytorch
that referenced
this pull request
Mar 23, 2022
Summary: Pull Request resolved: pytorch#74637 Forgot to update the expect file in pytorch#74242. Reland to include changes in expect file. Test Plan: unit test Differential Revision: D35089989 fbshipit-source-id: 7697274eff5333d218d522ef105c33b9f1e1ba70
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: #74242 The inputs and outputs of the graph module might be different from the graph inputs and outputs if users are using custom codegen. In interpreter, it runs the graph instead of the generated forward function so it might not work if user provides the inputs to the graph module. To fill the gap, we call `process_inputs` and `process_outputs` inside interpreter. Test Plan: unit test: test_interpreter_with_codegen Reviewed By: jamesr66a, Chillee Differential Revision: D34898108 fbshipit-source-id: 250bd236f6c8c1268a363cf19a09521a4f64b3a9 (cherry picked from commit b33076f)
|
This pull request has been reverted by bf5e25f. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The inputs and outputs of the graph module might be different from the graph inputs and outputs if users are using custom codegen. In interpreter, it runs the graph instead of the generated forward function so it might not work if user provides the inputs to the graph module. To fill the gap, we call
process_inputsandprocess_outputsinside interpreter.Test Plan: unit test: test_interpreter_with_codegen
Differential Revision: D34898108