fix kl_div for negative targets #69212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
This was referenced Dec 1, 2021
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c96a77d (more details on the Dr. CI page):
🕵️ 16 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced Dec 1, 2021
[ghstack-poisoned]
cc albanD mruberry jbschlosser walterddr [ghstack-poisoned]
cc albanD mruberry jbschlosser walterddr [ghstack-poisoned]
cc albanD mruberry jbschlosser walterddr [ghstack-poisoned]
cc albanD mruberry jbschlosser walterddr [ghstack-poisoned]
cc albanD mruberry jbschlosser walterddr [ghstack-poisoned]
cc albanD mruberry jbschlosser walterddr [ghstack-poisoned]
|
@jbschlosser This one does not make it fully composite, but we could simply remove the backward formulas so that it is fully composite (I'd vouch for that). Philip is on PTO, but I could carve these PRs out of this stack and standalone PR that does so. |
|
@lezcano Sure, that sounds great if you're willing to do it! |
lezcano
added a commit
that referenced
this pull request
Jun 27, 2022
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 4, 2022
Benchmarks: #80334 (comment) Fixes #80158 Fixes #78867 Fixes #69230 Supersedes #79007 Supersedes #69212 Supersedes #19659 Pull Request resolved: #80334 Approved by: https://github.com/ezyang
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Summary: Benchmarks: #80334 (comment) Fixes #80158 Fixes #78867 Fixes #69230 Supersedes #79007 Supersedes #69212 Supersedes #19659 Pull Request resolved: #80334 Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/828c787ea98da39eb786925eedcb8527aae07153 Reviewed By: mehtanirav Differential Revision: D37604775 Pulled By: mehtanirav fbshipit-source-id: b188d47df5a3a820e5c15d9ce18b1a2c3f31f287
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 13, 2022
Benchmarks: #80334 (comment) Fixes #80158 Fixes #78867 Fixes #69230 Supersedes #79007 Supersedes #69212 Supersedes #19659 Pull Request resolved: #80334 Approved by: https://github.com/ezyang
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
Summary: Benchmarks: #80334 (comment) Fixes #80158 Fixes #78867 Fixes #69230 Supersedes #79007 Supersedes #69212 Supersedes #19659 Pull Request resolved: #80334 Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b5b9db9f844f4f100651c6afa57124fa5851edec Reviewed By: DanilBaibak Differential Revision: D37847477 Pulled By: DanilBaibak fbshipit-source-id: a04919bbd2b746c30c654b971efcf76ef27ac5a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
torch.nn.functional.l1_lossfor complex inputs #65681OpInfos fortorch.nn.functional.triplet_margin(_with_distance)?_loss#67079OpInfos fornn.functional.binary_cross_entropy(_with_logits)?#67023OpInfofortorch.nn.functional.pdist#67022OpInfofortorch.nn.functional.(smooth_)?l1_loss#69211cc @albanD @mruberry @jbschlosser @walterddr