Adding custom testing based on opinfos input for ops with custom rules. #67500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2d6d3c1 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Oct 29, 2021
Closed
…custom rules." [ghstack-poisoned]
…custom rules." [ghstack-poisoned]
Krovatkin
approved these changes
Oct 29, 2021
| weight, bias = conv_in.args | ||
| weight = weight.type(torch.long) | ||
|
|
||
| with self.assertRaises(RuntimeError): |
There was a problem hiding this comment.
can have a test to assert that dtype_propagation doesn't dtype the output tensor in this case?
There was a problem hiding this comment.
Makes sense. I'll have to add a bit more logic to handle that.
| (conv2d_fn, sample_inputs_conv2d), | ||
| (adaptive_avg_pool2d_fn, sample_inputs_adaptive_avg_pool2d), | ||
| ): | ||
| for dtype in (torch.int8, torch.float64): |
There was a problem hiding this comment.
how did you decide on these two types?
There was a problem hiding this comment.
Just seemed like two types that would be commonly used, and I wanted one int, and one float type
…custom rules." [ghstack-poisoned]
…custom rules." [ghstack-poisoned]
…custom rules."
[ghstack-poisoned]<
8000
/pre>
…custom rules." [ghstack-poisoned]
|
@Gamrix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…custom rules." Differential Revision: [D32175957](https://our.internmc.facebook.com/intern/diff/D32175957) [ghstack-poisoned]
|
@Gamrix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…custom rules." Differential Revision: [D32175957](https://our.internmc.facebook.com/intern/diff/D32175957) [ghstack-poisoned]
|
@Gamrix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This pull request has been reverted by b1ac7f5. To re-land this change, follow these steps. |
6D40
Closed
Closed
…custom rules." Differential Revision: [D32175957](https://our.internmc.facebook.com/intern/diff/D32175957) [ghstack-poisoned]
…custom rules." * #66898 [ghstack-poisoned]
|
@Gamrix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D32497547