8000 Add ability for a mobile::Module to save as flatbuffer by qihqi · Pull Request #67351 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ability for a mobile::Module to save as flatbuffer #67351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add ability for a mobile::Module to save as flatbuffer #67351

wants to merge 1 commit into from

Conversation

qihqi
Copy link
Contributor
@qihqi qihqi commented Oct 27, 2021

Included functions:

  • save_mobile_module -> saves a mobile::Module to flatbuffer
  • load_mobile_module_from_file -> loads a flatbuffer into mobile::Module
  • parse_mobile_module -> parses from bytes or deserialized flatbuffer
    Module object

Fixes #{issue number}

@qihqi qihqi requested review from gmagogsfm and iseeyuan October 27, 2021 18:38
@pytorch-probot
Copy link
pytorch-probot bot commented Oct 27, 2021 •
edited
Loading
CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/qihqi/pytorch/blob/f7c1a3c7ab6c4c3fc3376a4b20f71f75175c49da/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-cuda11.5-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/xla ✅ triggered
linux-vulkan-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile ✅ triggered
linux-xenial-py3.6-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers ✅ triggered
linux-xenial-py3.6-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
docker-builds ciflow/all 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-arm64-full-jit ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-x86-64-full-jit ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
libtorch-linux-bionic-cuda11.5-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos 🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Oct 27, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit f7c1a3c (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 27, 2021
@qihqi qihqi force-pushed the flatbuffer-real branch 3 times, most recently from 7c11ba0 to 47f2865 Compare October 29, 2021 00:00
@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@qihqi qihqi force-pushed the flatbuffer-real branch 8 times, most recently from cc08078 to 125b945 Compare November 5, 2021 03:25
@qihqi qihqi force-pushed the flatbuffer-real branch 4 times, most recently from 529380a to cec2721 Compare November 6, 2021 00:20
@qihqi qihqi force-pushed the flatbuffer-real branch 3 times, most recently from 36e52b1 to 3254842 Compare November 8, 2021 17:34
@zhxchen17 zhxchen17 self-requested a review November 13, 2021 00:12
qihqi
qihqi commented Nov 15, 2021
View reviewed changes
torch/csrc/jit/serialization/mobile_bytecode.fbs
type_name:string;
type: TypeType;
// Below fields are optional
attr_names:[string];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attach function

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32010095

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32010095

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32010095

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32010095

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32010095

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32010095

@facebook-github-bot
Copy link
8000 Contributor

This pull request was exported from Phabricator. Differential Revision: D32010095

@qihqi @facebook-github-bot
Add ability for a mobile::Module to save as flatbuffer (pytorch#67351)
f7c1a3c 
Summary:
Included functions:

* save_mobile_module -> saves a mobile::Module to flatbuffer
* load_mobile_module_from_file -> loads a flatbuffer into mobile::Module
* parse_mobile_module -> parses from bytes or deserialized flatbuffer
      Module object

Fixes #{issue number}

Pull Request resolved: pytorch#67351

Reviewed By: iseeyuan

Differential Revision: D32010095

Pulled By: qihqi

fbshipit-source-id: 11f43641033c9eaf96f9529a7925e781bba26821
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32010095

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 00ebbd5. To re-land this change, follow these steps.

@suo suo mentioned this pull request Dec 3, 2021
Closed
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 00ebbd5. To re-land this change, follow these steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhxchen17 zhxchen17 zhxchen17 left review comments

@cccclai cccclai cccclai left review comments

@pavithranrao pavithranrao pavithranrao left review comments

@iseeyuan iseeyuan iseeyuan approved these changes

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm

Assignees
No one assigned
Labels
cla signed oncall: jit Add this issue/PR to JIT oncall triage queue Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qihqi @facebook-github-bot @iseeyuan @zhxchen17 @cccclai @pavithranrao
0