8000 Split cuda: list cpp files that go in _cu library explicitly by peterbell10 · Pull Request #67216 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Split cuda: list cpp files that go in _cu library explicitly #67216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

Split cuda: list cpp files that go in _cu library explicitly #67216

wants to merge 21 commits into from

Conversation

peterbell10
Copy link
Collaborator
@peterbell10 peterbell10 commented Oct 25, 2021 •
edited
Loading

@peterbell10 peterbell10 mentioned this pull request Oct 25, 2021
Closed
@pytorch-probot
Copy link
pytorch-probot bot commented Oct 25, 2021 •
edited
Loading
CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/fea074a9ad1eae4671c1168060fcf255d015aae5/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/xla ✅ triggered
linux-vulkan-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile ✅ triggered
linux-xenial-py3.6-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers ✅ triggered
linux-xenial-py3.6-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
docker-builds ciflow/all 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-arm64-full-jit ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
ios-12-5-1-x86-64-full-jit ciflow/all, ciflow/ios, ciflow/macos 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflo 8000 w/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos 🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@peterbell10 peterbell10 mentioned this pull request Oct 25, 2021
Closed
@peterbell10 peterbell10 mentioned this pull request Oct 25, 2021
Closed
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Oct 25, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit fea074a (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Oct 25, 2021
Closed
Closed
Closed
Closed
Closed
peterbell10 added a commit that referenced this pull request Oct 25, 2021
@peterbell10
Split cuda: list cpp files that go in _cu library explicitly
de7d491 
ghstack-source-id: 7047863
Pull Request resolved: #67216
@peterbell10 peterbell10 requested a review from dagitses October 25, 2021 21:29
peterbell10 added a commit that referenced this pull request Oct 26, 2021
@peterbell10
Split cuda: list cpp files that go in _cu library explicitly
1e34c48 
ghstack-source-id: ced73aa
Pull Request resolved: #67216
dagitses pushed a commit that referenced this pull request Nov 2, 2021
Split cuda: list cpp files that go in _cu library explicitly
bf795ca 
ghstack-source-id: 04542b0
Pull Request resolved: #67216
@dagitses
Copy link
Collaborator
dagitses commented Nov 2, 2021

@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

peterbell10 added a commit that referenced this pull request Nov 2, 2021
@peterbell10
Split cuda: list cpp files that go in _cu library explicitly
ec7b249 
ghstack-source-id: c562c2b
Pull Request resolved: #67216
@peterbell10 peterbell10 mentioned this pull request Nov 2, 2021
Closed
@dagitses
Copy link
Collaborator
dagitses commented Nov 3, 2021

@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dagitses
Copy link
Collaborator
dagitses commented Nov 4, 2021

@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This was referenced Nov 4, 2021
Closed
Closed
@dagitses
Copy link
Collaborator

@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dagitses
Copy link
Collaborator

@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dagitses
Copy link
Collaborator

@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dagitses
Copy link
Collaborator

@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

6D40
@dagitses
Copy link
Collaborator

@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@dagitses merged this pull request in b47ae98.

@malfet
Copy link
Contributor
malfet commented Nov 30, 2021

This PR broke bunch of OSS builds, looks like a land race, see https://github.com/pytorch/pytorch/runs/4367296111?check_suite_focus=true

@peterbell10
Copy link
Collaborator Author

Yes, #69082 will fix it.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by d3de354. To re-land this change, follow these steps.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/190/head branch December 3, 2021 15:17
@malfet malfet mentioned this pull request Dec 7, 2021
Closed
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by d3de354. To re-land this change, follow these steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagitses dagitses dagitses approved these changes

Assignees
No one assigned
Labels
cla signed Merged open source Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterbell10 @facebook-github-bot @dagitses @malfet @pytorchbot
0