Fix cang-tidy regressions caused by #65954 #66040

malfet · 2021-10-02T01:07:13Z

No description provided.

pytorch-probot · 2021-10-02T01:07:15Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/malfet/pytorch/blob/b57bd27a3805f13372b897d4e2f5b74a93b24f89/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default,ciflow/libtorch

Workflows	Labels (bold enabled)	Status
Triggered Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	✅ triggered
libtorch-linux-xenial-cuda11.3-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	✅ triggered
linux-bionic-py3.6-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/xla`	✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3.6-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`	✅ triggered
linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3.6-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/win`	✅ triggered
Skipped Workflows
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`	🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`	🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
puretorch-linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

facebook-github-bot · 2021-10-02T01:07:18Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/66040
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit b57bd27 (more details on the Dr. CI page):

3/4 failures introduced in this PR
1/4 tentatively recognized as flaky ❄️
- Click here to rerun these jobs

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_clang7_onnx_ort_test1 (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Oct 02 03:08:10 ../../../../opt/conda/lib/pytho...WeightedSample::test_weighted_sample FAILED [ 98%]

Oct 02 03:08:08 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_lengths_to_ranges PASSED [ 98%]
Oct 02 03:08:08 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_nan_check PASSED [ 98%]
Oct 02 03:08:08 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_range PASSED [ 98%]
Oct 02 03:08:08 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_resize_like PASSED [ 98%]
Oct 02 03:08:08 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_size_op PASSED [ 98%]
Oct 02 03:08:09 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_slice PASSED [ 98%]
Oct 02 03:08:09 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_sum PASSED [ 98%]
Oct 02 03:08:09 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_transpose PASSED [ 98%]
Oct 02 03:08:09 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/weight_scale_test.py::TestWeightScale::test_weight_scale PASSED [ 98%]
Oct 02 03:08:09 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/weighted_multi_sample_test.py::TestWeightedMultiSample::test_weighted_multi_sample PASSED [ 98%]
Oct 02 03:08:10 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/weighted_sample_test.py::TestWeightedSample::test_weighted_sample FAILED [ 98%]
Oct 02 03:08:10 
Oct 02 03:08:10 =================================== FAILURES ===================================
Oct 02 03:08:10 ___________________ TestWeightedSample.test_weighted_sample ____________________
Oct 02 03:08:10 
Oct 02 03:08:10 self = <caffe2.python.operator_test.weighted_sample_test.TestWeightedSample testMethod=test_weighted_sample>
Oct 02 03:08:10 
Oct 02 03:08:10     @given(
Oct 02 03:08:10 >       batch=st.integers(min_value=0, max_value=128),
Oct 02 03:08:10         weights_len=st.integers(min_value=0, max_value=128),
Oct 02 03:08:10         **hu.gcs

pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Oct 02 03:09:26 ../../../../opt/conda/lib/pytho...WeightedSample::test_weighted_sample FAILED [ 98%]

Oct 02 03:09:24 ../../../../opt/conda/lib/python3.6/site
8000
-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_lengths_to_ranges PASSED [ 98%]
Oct 02 03:09:25 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_nan_check PASSED [ 98%]
Oct 02 03:09:25 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_range PASSED [ 98%]
Oct 02 03:09:25 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_resize_like PASSED [ 98%]
Oct 02 03:09:25 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_size_op PASSED [ 98%]
Oct 02 03:09:25 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_slice PASSED [ 98%]
Oct 02 03:09:25 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_sum PASSED [ 98%]
Oct 02 03:09:26 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/utility_ops_test.py::TestUtilityOps::test_transpose PASSED [ 98%]
Oct 02 03:09:26 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/weight_scale_test.py::TestWeightScale::test_weight_scale PASSED [ 98%]
Oct 02 03:09:26 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/weighted_multi_sample_test.py::TestWeightedMultiSample::test_weighted_multi_sample PASSED [ 98%]
Oct 02 03:09:26 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/weighted_sample_test.py::TestWeightedSample::test_weighted_sample FAILED [ 98%]
Oct 02 03:09:26 
Oct 02 03:09:26 =================================== FAILURES ===================================
Oct 02 03:09:26 ___________________ TestWeightedSample.test_weighted_sample ____________________
Oct 02 03:09:26 
Oct 02 03:09:26 self = <caffe2.python.operator_test.weighted_sample_test.TestWeightedSample testMethod=test_weighted_sample>
Oct 02 03:09:26 
Oct 02 03:09:26     @given(
Oct 02 03:09:26 >       batch=st.integers(min_value=0, max_value=128),
Oct 02 03:09:26         weights_len=st.integers(min_value=0, max_value=128),
Oct 02 03:09:26         **hu.gcs

1 failure not recognized by patterns:

Job	Step	Action
^{binary_linux_libtorch_3_7m_cpu_gcc5_4_cxx11-abi_shared-with-deps_build}	^Build	🔁 rerun

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 / build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun) ❄️

2021-10-02T02:46:36.1830376Z E: Failed to fetch...: /etc/ssl/certs/ca-certificates.crt CRLfile: none

2021-10-02T02:46:33.2784562Z ++ [[ periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 == *centos* ]]
2021-10-02T02:46:33.2785980Z ++ [[ periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 == *linux-bionic* ]]
2021-10-02T02:46:33.2787434Z + [[ periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 == *-clang7-asan* ]]
2021-10-02T02:46:33.2788871Z + [[ periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 == *-mobile-*build* ]]
2021-10-02T02:46:33.2790382Z + [[ periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 == *-mobile-code-analysis* ]]
2021-10-02T02:46:33.2791948Z + [[ periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 == *linux-xenial-cuda11.1* ]]
2021-10-02T02:46:33.2792849Z + export USE_DEPLOY=ON
2021-10-02T02:46:33.2793169Z + USE_DEPLOY=ON
2021-10-02T02:46:33.2793582Z + sudo apt-get -qq update
2021-10-02T02:46:36.1828565Z W: The repository 'https://deb.nodesource.com/node_12.x xenial Release' does not have a Release file.
2021-10-02T02:46:36.1830376Z E: Failed to fetch https://deb.nodesource.com/node_12.x/dists/xenial/main/source/Sources  server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
2021-10-02T02:46:36.1831499Z E: Some index files failed to download. They have been ignored, or old ones used instead.
2021-10-02T02:46:36.1837656Z + cleanup
2021-10-02T02:46:36.1838125Z + retcode=100
2021-10-02T02:46:36.1838655Z + set +x
2021-10-02T02:46:36.1839019Z =================== sccache compilation log ===================
2021-10-02T02:46:36.2061507Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2021-10-02T02:46:36.2081420Z Compile requests                      0
2021-10-02T02:46:36.2082055Z Compile requests executed             0
2021-10-02T02:46:36.2082437Z Cache hits                            0
2021-10-02T02:46:36.2082767Z Cache misses                          0

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot · 2021-10-02T01:07:27Z

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-10-02T01:36:53Z

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Also, build `libtorch` with `-Wno-unused-variable` (as it includes JNI library, that violates that rules)

ZolotukhinM

👍

facebook-github-bot · 2021-10-02T02:11:41Z

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

malfet · 2021-10-02T02:42:11Z

@pytorchbot ciflow rerun -l ciflow/libtorch

facebook-github-bot · 2021-10-02T03:37:02Z

This pull request has been reverted by 5ef350d. To re-land this change, follow these steps.

malfet added the ciflow/all label Oct 2, 2021

malfet force-pushed the malfet/fix-clang-tidy branch from b1319da to 0604cc3 Compare October 2, 2021 01:22

facebook-github-bot added the cla signed label Oct 2, 2021

malfet force-pushed the malfet/fix-clang-tidy branch from 0604cc3 to 9da7b63 Compare October 2, 2021 01:34

malfet added the with-ssh label Oct 2, 2021

8000

malfet requested a review from a team October 2, 2021 01:36

Fix cang-tidy regressions caused by pytorch#65954

b57bd27

Also, build `libtorch` with `-Wno-unused-variable` (as it includes JNI library, that violates that rules)

malfet force-pushed the malfet/fix-clang-tidy branch from 9da7b63 to b57bd27 Compare October 2, 2021 01:59

ZolotukhinM self-requested a review October 2, 2021 02:06

ZolotukhinM approved these changes Oct 2, 2021

View reviewed changes

pytorch-probot bot added ciflow/default and removed ciflow/all labels Oct 2, 2021

pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Oct 2, 2021

facebook-github-bot closed this in c269f47 Oct 2, 2021

facebook-github-bot added the Reverted label Oct 2, 2021

malfet deleted the malfet/fix-clang-tidy branch October 2, 2021 03:39

malfet mentioned this pull request Oct 5, 2021

Some workflows does not seem to be triggered by GHA #66110

Closed

janeyx99 mentioned this pull request Oct 12, 2021

[Meta] CI Revert Tracker #66178

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix cang-tidy regressions caused by #65954 #66040

Fix cang-tidy regressions caused by #65954 #66040

Uh oh!

Uh oh!

⚛️ CI Flow

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fix cang-tidy regressions caused by #65954 #66040

Fix cang-tidy regressions caused by #65954 #66040

Uh oh!

Conversation

Uh oh!

Uh oh!

⚛️ CI Flow

Uh oh!

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

pytorch_linux_xenial_py3_clang7_onnx_ort_test1 (1/2)

pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (2/2)

1 failure not recognized by patterns:

❄️ 1 failure tentatively classified as flaky

periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 / build (1/1)

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!