topk on CUDA supports bfloat16
#59977
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 804c3a8 (more details on the Dr. CI page and at hud.pytorch.org/pr/59977):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
running CI to see what happens on ROCM, probably need to add skips for the new tests |
|
ROCm is failing as expected, you need to adjust skips. |
ngimel
reviewed
Jun 22, 2021
ngimel
approved these changes
Jun 22, 2021
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ngimel
reviewed
Jun 22, 2021
| small = 10 | ||
| large = 8192 | ||
| for curr_size in (small, large): | ||
| self._test_topk_dtype(device, dtype, False, curr_size) | ||
|
|
||
| @dtypesIfCUDA(*torch.testing.get_all_fp_dtypes()) |
There was a problem hiding this comment.
you probably should include_bfloat16=True here, otherwise it's not tested
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 28, 2022
Support for PR #[59977](#59977) in ROCm Fixes #[56176](#56176) in ROCm since ROCm 5.0 supports dtype bfloat16 for sorting. Dependency - PR #[72854](#72854) to be merged before CC Please review @jithunnair-amd @jeffdaily Pull Request resolved: #71913 Approved by: https://github.com/jithunnair-amd, https://github.com/osalpekar
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2022
Summary: Support for PR #[59977](#59977) in ROCm Fixes #[56176](#56176) in ROCm since ROCm 5.0 supports dtype bfloat16 for sorting. Dependency - PR #[72854](#72854) to be merged before CC Please review jithunnair-amd jeffdaily Pull Request resolved: #71913 Approved by: https://github.com/jithunnair-amd, https://github.com/osalpekar Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6675f1e6970087cfc5ba67e7cf7690768e326464 Reviewed By: malfet Differential Revision: D35205235 fbshipit-source-id: 906575b43aa57d8674a774d812ebfcd0037f4617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56176 via #58196
CC @zasdfgbnm @ngimel @ptrblck