gloo: fix building system gloo with CUDA/HIP #146637
Conversation
Fix incorrect linking of Gloo's libraries when building with system Gloo. Previously, either Gloo's native library or Gloo's CUDA library were linked. However, Gloo had changed such that all users of Gloo must link the native library, and can optionally link the CUDA or HIP library for Gloo + CUDA/HIP support. This had been updated when building/linking with vendored Gloo, but not when using system Gloo. Fixes: pytorch#146239 Reported-by: Adam J Stewart <ajstewart426@gmail.com> Signed-off-by: Nathan Brown <nathan.brown@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146637
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e9bfe6f with merge base 5d81bc3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
|
Hello, Thanks, |
|
Pinging for review |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Waiting on @malfet or others for review |
|
Still waiting for review... |
Fix incorrect linking of Gloo's libraries when building with system Gloo. Previously, either Gloo's native library or Gloo's CUDA library were linked. However, Gloo had changed such that all users of Gloo must link the native library, and can optionally link the CUDA or HIP library for Gloo + CUDA/HIP support.
This had been updated when building/linking with vendored Gloo, but not when using system Gloo.
Fixes: #146239
Reported-by: Adam J Stewart ajstewart426@gmail.com
cc @malfet @seemethere @ptrblck @msaroufim @eqy @jerryzh168