Add suppo 8000 rt for torch exported model #2812
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaroufim
requested changes
Nov 28, 2023
| @@ -0,0 +1,62 @@ | |||
| # TorchServe inference with torch export model | |||
There was a problem hiding this comment.
there were some export related details on the main README as well could you consolidate?
|
|
||
| - `PyTorch >= 2.1.0` | ||
|
|
||
| Change directory to the root of `serve` |
| `torch.export.export()` takes a `torch.nn.Module` or a method along with sample inputs, and captures the computation graph into an `torch.export.ExportedProgram` | ||
|
|
||
| `torch.export` differs from `torch.compile` is a few ways | ||
| - JIT vs AOT |
There was a problem hiding this comment.
this needs a longer elaboration
| ### Create model archive | ||
|
|
||
| ``` | ||
| torch-model-archiver --model-name res18-pt2 --handler image_classifier --version 1.0 --serialized-file resnet18.pt2 --extra-files ./examples/image_classifier/index_to_name.json |
There was a problem hiding this comment.
you need to update the archiver code docstrings as well
msaroufim
requested changes
Nov 28, 2023
|
|
||
| `torch.export.export()` takes a `torch.nn.Module` or a method along with sample inputs, and captures the computation graph into an `torch.export.ExportedProgram` | ||
|
|
||
| `torch.export` differs from `torch.compile` is a few ways |
There was a problem hiding this comment.
you need to combo aot inductor with this story
|
torch.export.export by itself only creates an FX Graph representation of the model and serializes it. So, at inference, the model is executed in eager. Hence, even though this works, closing this PR as it doesn't make use of torch.compile |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Checklist: