Update CODEOWNERS #2581
Merged
Update CODEOWNERS #2581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the old setup Matthias had to review every PR that updated any test, that doesnt feel like it makes sense so just removing that rule entirely
Codecov Report
@@ Coverage Diff @@
## master #2581 +/- ##
=======================================
Coverage 70.87% 70.87%
=======================================
Files 83 83
Lines 3839 3839
Branches 58 58
=======================================
Hits 2721 2721
Misses 1114 1114
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
agunapal
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe CODEOWNERS was a bad idea since it can require a reviewer per folder so instead of needing 1 or 2 you might need more reviewers per PR
This was not my intent so would like to revert a CODEOWNERS policy