8000 fix example code for image classifier - resnet18 model by udaij12 · Pull Request #2568 · pytorch/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ serve Public
< 8000 /div>

fix example code for image classifier - resnet18 model #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix example code for image classifier - resnet18 model #2568

merged 1 commit into from
Sep 6, 2023

Conversation

udaij12
Copy link
Collaborator
@udaij12 udaij12 commented Sep 5, 2023 •
edited
Loading

Description

Update example code for resnet18 model under image classifier. Fixed instructions so that code would work as explained.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

No need for unit tests as just documentation update. Previous documentation said if path is: /home/my_path/serve, run the steps from /home/my_path however the code ./examples/ will not work from /my_path. So documentation updated to run the steps from /home/my_path/serve which fixes this issue.

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@msaroufim msaroufim enabled auto-merge September 6, 2023 04:26
@codecov
Copy link
codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #2568 (8e8ed48) into master (499d33d) will not change coverage.
The diff coverage is n/a.

❗ Current head 8e8ed48 differs from pull request most recent head f3093d9. Consider uploading reports for the commit f3093d9 to get more accurate results

@@           Coverage Diff           @@
##           master    #2568   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          79       79           
  Lines        3742     3742           
  Branches       58       58           
=======================================
  Hits         2721     2721           
  Misses       1017     1017           
  Partials        4        4

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim disabled auto-merge September 6, 2023 17:27
@msaroufim msaroufim enabled auto-merge September 6, 2023 17:27
@msaroufim msaroufim disabled auto-merge September 6, 2023 17:28
@msaroufim msaroufim enabled auto-merge September 6, 2023 17:28
@msaroufim msaroufim added this pull request to the merge queue Sep 6, 2023
Merged via the queue into pytorch:master with commit 7253668 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaroufim msaroufim msaroufim approved these changes

@agunapal agunapal agunapal approved these changes

@HamidShojanazeri HamidShojanazeri Awaiting requested review from HamidShojanazeri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@udaij12 @msaroufim @agunapal
0