8000 Align make_private_with_epsilon with make_private by alexandresablayrolles · Pull Request #509 · pytorch/opacus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Align make_private_with_epsilon with make_private #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Align make_private_with_epsilon with make_private #509

wants to merge 2 commits into from

Conversation

alexandresablayrolles
Copy link
Contributor

Fixes #467

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2022
ffuuugor
ffuuugor approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor
@ffuuugor ffuuugor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks!

Accepting to unblock - please make sure tests pass before landing, you've put "max_grad_norm" in there twice

@facebook-github-bot
Copy link
Contributor

@alexandresablayrolles has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@karthikprasad karthikprasad deleted the align_make_private_epsilon branch September 27, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikprasad karthikprasad karthikprasad approved these changes

@ffuuugor ffuuugor ffuuugor approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mismatch between the documentation and the behaviour of make_private_with_epsilon
4 participants
@alexandresablayrolles @facebook-github-bot @karthikprasad @ffuuugor
0