8000 Add doctest for StepStateScheduler by bibhabasumohapatra · Pull Request #2394 · pytorch/ignite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add doctest for StepStateScheduler #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Dec 29, 2021
Merged

Add doctest for StepStateScheduler #2394

merged 20 commits into from
Dec 29, 2021

Conversation

bibhabasumohapatra
Copy link
Contributor
@bibhabasumohapatra bibhabasumohapatra commented Dec 29, 2021 •
edited by sdesrozis
Loading

Addresses #2266
Description:
added doctest for StepStateScheduler
Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format

@github-actions github-actions bot added the module: handlers Core Handlers module label Dec 29, 2021
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
8000
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
@sdesrozis
Copy link
Contributor

@bibhabasumohapatra Thanks ! I left a few minor comments to address. The point is to be consistent witth the previous PR.

bibhabasumohapatra and others added 10 commits December 29, 2021 14:11
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
a96a2ae 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
67dc4be 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
8d4e0a9 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
d0d4a67 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
4fddacb 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
868ddc8 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
48618ff 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
7d34e9e 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
1817a48 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
82c774b 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra
Copy link
Contributor Author

@bibhabasumohapatra Thanks ! I left a few minor comments to address. The point is to be consistent with the previous PR.

wanted to point out epoch ... for clarity, but yes Consistency is valid point.

sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
bibhabasumohapatra and others added 2 commits December 29, 2021 14:42
@bibhabasumohapatra
Update state_param_scheduler.py
55c0a3c
@bibhabasumohapatra @sdesrozis
Update ignite/handlers/state_param_scheduler.py
cc539e8 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
@bibhabasumohapatra bibhabasumohapatra mentioned this pull request Dec 29, 2021
Merged
sdesrozis
sdesrozis suggested changes Dec 29, 2021
View reviewed changes
Copy link
Contributor
@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, address the comment #2394 (comment)

sdesrozis
sdesrozis reviewed Dec 29, 2021
View reviewed changes
sdesrozis
sdesrozis approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor
@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bibhabasumohapatra Thanks, LGTM !

@sdesrozis sdesrozis merged commit ec6bacc into pytorch:master Dec 29, 2021
@sdesrozis sdesrozis mentioned this pull request Dec 29, 2021
Closed
15 tasks
@bibhabasumohapatra bibhabasumohapatra deleted the doc-StepStateScheduler branch January 2, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis approved these changes

Assignees
No one assigned
Labels
module: handlers Core Handlers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bibhabasumohapatra @sdesrozis
0