8000 Remove unnecessary test prints by nzare · Pull Request #1282 · pytorch/ignite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove unnecessary test prints #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Remove unnecessary test prints #1282

wants to merge 8 commits into from

Conversation

nzare
Copy link
Contributor
@nzare nzare commented Sep 12, 2020

Fixes #1240

Remove useless prints from tests

vfdev-5
vfdev-5 reviewed Sep 12, 2020
View reviewed changes
Copy link
Collaborator
@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I left a comment in the code.
Could you please also remove :

@nzare
Copy link
Contributor Author
nzare commented Sep 12, 2020

Can you please review it now ?
Thank You

@vfdev-5
Copy link
Collaborator
vfdev-5 commented Sep 12, 2020

@nzare could you please fix flake8 error : https://travis-ci.org/github/pytorch/ignite/jobs/726552697#L242

@nzare
Copy link
Contributor Author
nzare commented Sep 12, 2020

I checked flake8 error
./tests/ignite/metrics/test_top_k_categorical_accuracy.py:70:1: W293 blank line contains whitespace

I tried fixing with autopep and tried changing spacing etc but none of them seems to work

@vfdev-5
Copy link
Collaborator
vfdev-5 commented Sep 12, 2020 via email

@vfdev-5
Copy link
Collaborator
vfdev-5 commented Sep 14, 2020 •
edited
Loading

@nzare could you please merge master branch to this PR as it modifies back a recent commit. Thanks

FYI: currently the CI is broken due a fail with new tqdm version. Hopefully, it can be fixed soon, #1287.

@nzare nzare mentioned this pull request Sep 15, 2020
Merged
@nzare
Copy link
Contributor Author
nzare commented Sep 15, 2020

Merged master and opened a new pull request as it was facing some merging issue.
#1292

@nzare nzare closed this Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove useless prints from tests
2 participants
@nzare @vfdev-5
0