8000 Fix CuptiActivity name from tpp to cpp by aaronenyeshi · Pull Request #631 · pytorch/kineto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix CuptiActivity name from tpp to cpp #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix CuptiActivity name from tpp to cpp #631

wants to merge 1 commit into from

Conversation

aaronenyeshi
Copy link
Member

Summary: There was a typo in the naming of this file when it was created causing a suffix .tpp. Fix this to .cpp.

Reviewed By: slgong-fb

Differential Revision: D37967514

Pulled By: aaronenyeshi

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37967514

@aaronenyeshi
Copy link
Member Author

Hi @robieta and @malfet , is there a regression in the latest nightly profiler test? Our CI seems to be failing for a trivial change.

2022-07-19T20:00:19.7684835Z _________ TestCompareWithAutogradResult.test_profiler_api_without_gpu __________
2022-07-19T20:00:19.7685057Z 
2022-07-19T20:00:19.7685302Z self = <test_compare_with_autograd.TestCompareWithAutogradResult testMethod=test_profiler_api_without_gpu>
2022-07-19T20:00:19.7685609Z 
2022-07-19T20:00:19.7685750Z     def test_profiler_api_without_gpu(self):
2022-07-19T20:00:19.7686035Z >       self.base_profiler_api(False, True, True, False)
2022-07-19T20:00:19.7686200Z 
2022-07-19T20:00:19.7686310Z test_compare_with_autograd.py:279: 
2022-07-19T20:00:19.7686563Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
2022-07-19T20:00:19.7686839Z test_compare_with_autograd.py:276: in base_profiler_api
2022-07-19T20:00:19.7687168Z     self.compare_results(log_dir, profilers_dict, use_gpu, record_shapes, with_stack)
2022-07-19T20:00:19.7687497Z test_compare_with_autograd.py:243: in compare_results
2022-07-19T20:00:19.7687779Z     self.assertTrue(line in autograd_result[key])
2022-07-19T20:00:19.7688032Z E   AssertionError: False is not true

@robieta
Copy link
robieta commented Jul 19, 2022

I feel like it's probably pytorch/pytorch#80796, but since the test give no addition information it's hard to tell.

@aaronenyeshi
Copy link
Member Author

Issue seems to have started between July 14 - 18. https://github.com/pytorch/kineto/actions/workflows/tb_plugin_ci.yml

@robieta
Copy link
robieta commented Jul 19, 2022

After some digging, my conclusion is that we should disable it. TensorBoard has no business unit testing the internals of profiler; if it wants this functionality it should be in PyTorch CI, not kineto CI.

@aaronenyeshi
Copy link
Member Author

I will take a look at the TB_Plugin_CI and disable this test, I'm not sure why we are running it in TB.

@slgong-fb slgong-fb mentioned this pull request Jul 19, 2022
Closed
aaronenyeshi added a commit that referenced this pull request Jul 19, 2022
@aaronenyeshi
Disable test_profiler_api_without_gpu in TB CI
52f68fd 
As discussed with Taylor in #631, test_profiler_api_without_gpu should be disabled in TB_Plugin_CI, and if we want this to exist, it should exist in PyTorch CI.
@aaronenyeshi aaronenyeshi mentioned this pull request Jul 19, 2022
Closed
facebook-github-bot pushed a commit that referenced this pull request Jul 20, 2022
@aaronenyeshi @facebook-github-bot
Disable test_profiler_api_without_gpu in TB CI (#632)
29fbe21 
Summary:
As discussed with Taylor in #631, test_profiler_api_without_gpu should be disabled in TB_Plugin_CI, and if we want this to exist, it should exist in PyTorch CI.

Pull Request resolved: #632

Reviewed By: chaekit

Differential Revision: D37978640

Pulled By: aaronenyeshi

fbshipit-source-id: 2c293eb298db49e3ba6b68b101117282c42be4a6
@aaronenyeshi @facebook-github-bot
Fix CuptiActivity name from tpp to cpp (pytorch#631)
d1f5ffc 
Summary:
Pull Request resolved: pytorch#631

There was a typo in the naming of this file when it was created causing a suffix .tpp. Fix this to .cpp.

Test Plan: CI Tests

Reviewed By: slgong-fb

Differential Revision: D37967514

Pulled By: aaronenyeshi

fbshipit-source-id: 90bccf2c00fb6f89f85d702a62d93defa6ee1547
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37967514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronenyeshi @facebook-github-bot @robieta
0