Clear Buffer When Toggling #1102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Get rid of extraneous events when toggling. We have seen that in D76431700 there can sometimes be a build up of "junk" events in CUPTI sent over because we are turning off activities without flushing. We should flush whenever we toggle to make sure these events get dropped Differential Revision: D76453586
|
This pull request was exported from Phabricator. Differential Revision: D76453586 |
| @@ -1198,18 +1198,22 @@ void CuptiActivityProfiler::ensureCollectTraceDone() { | |||
| void CuptiActivityProfiler::toggleCollectionDynamic(const bool enable) { | |||
| #ifdef HAS_CUPTI | |||
| if (enable) { | |||
| cupti_.clearActivities(); | |||
There was a problem hiding this comment.
I feel what we need is a flush rather than clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Get rid of extraneous events when toggling. We have seen that in D76431700 there can sometimes be a build up of "junk" events in CUPTI sent over because we are turning off activities without flushing. We should flush whenever we toggle to make sure these events get dropped
Differe 8000 ntial Revision: D76453586