8000 This PR Improve docs build ci by soot-bit · Pull Request #1336 · pytorch/examples · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

This PR Improve docs build ci #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

This PR Improve docs build ci #1336

wants to merge 4 commits into from

Conversation

soot-bit
Copy link
@soot-bit soot-bit commented Apr 30, 2025 •
edited
Loading

This PR Improve docs build ci

Changes:

  • removed redundant dependencies (git, make, python3-venv) from the GitHub Actions workflow, as they are preinstalled on ubuntu-latest runners.
  • Removed deprecated panels_add_bootstrap_css
  • Created _static directory to resolve warnings.

Testing:

  • Verified locally with make html (no errors/warnings).

@netlify Netlify
Copy link
netlify bot commented Apr 30, 2025 •
edited
Loading

✅ Deploy Preview for pytorch-examples-preview ready!

Name Link
🔨 Latest commit ee68721
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/681539696d9bac0008377221
😎 Deploy Preview https://deploy-preview-1336--pytorch-examples-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dvrogozh
dvrogozh suggested changes May 2, 2025
View reviewed changes
Copy link
Contributor
@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1333 already addressed docs build. This PR suggests some improvements on top. I think it's better to change PR title accordingly saying for example "Improve docs build ci"

This was referenced May 2, 2025
Open
Open
dvrogozh
dvrogozh reviewed May 2, 2025
View reviewed changes
dvrogozh
dvrogozh reviewed May 2, 2025
View reviewed changes
Copy link
Contributor
@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created _static directory to resolve warnings.

You don't do that in the PR. Or that's done implicit?

Fix documentation build: GitHub Actions, Sphinx 5.3.0, and theme comp…

I suggest to change PR title to "Improved documentation ci build"

@soot-bit soot-bit changed the title Fix documentation build: GitHub Actions, Sphinx 5.3.0, and theme comp… This PR Improve docs build ci May 3, 2025
@soot-bit soot-bit changed the title This PR Improve docs build ci This PR Improve docs build ci May 3, 2025
@dvrogozh
Copy link
Contributor
dvrogozh commented May 5, 2025

The _static directory was explicitly created in this PR to resolve sphinx warnings about missing paths.

You don't have this in your PR code change. Did you forget to amend?

@soot-bit
Copy link
Author
soot-bit commented May 7, 2025

The _static directory was explicitly created in this PR to resolve sphinx warnings about missing paths.

You don't have this in your PR code change. Did you forget to amend?

image
its here ,

@dvrogozh
Copy link
Contributor
dvrogozh commented May 7, 2025

its here

I overlooked it. Thank you for pointing out.

dvrogozh
dvrogozh approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor
@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @msaroufim, can you, please, take a look on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvrogozh dvrogozh dvrogozh approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soot-bit @dvrogozh @facebook-github-bot
0