Fix aqt implementation for aten.mm/aten.addmm fallback path #2072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously in try except there was a side effect of transposing weight_tensor, even if the dispatch failed, this could cause errors in the fallback path. This PR fixes it. Test Plan: python test/dtypes/test_affine_quantized.py -k test_matmul Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2072
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b3d321f with merge base a61e302 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jcaip
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously in try except there was a side effect of transposing weight_tensor, even if the dispatch failed, this could cause errors in the fallback path. This PR fixes it.
Test Plan:
python test/dtypes/test_affine_quantized.py -k test_matmul
Reviewers:
Subscribers:
Tasks:
Tags: