8000 fix: Remove references to implicit batch for TRT 10 by gs-olive · Pull Request #2773 · pytorch/TensorRT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Remove references to implicit batch for TRT 10 #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: Remove references to implicit batch for TRT 10 #2773

merged 1 commit into from
Apr 23, 2024

Conversation

gs-olive
Copy link
Collaborator
@gs-olive gs-olive commented Apr 23, 2024 •
edited
Loading

Description

  • Remove references to network.has_implicit_batch_dimension for TRT 10
  • Default network.has_implicit_batch_dimension=False

Type of change

  • Remove deprecated code

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
    • Validated in CI
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Apr 23, 2024
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Apr 23, 2024
@github-actions github-actions bot requested a review from apbose April 23, 2024 16:21
peri044
peri044 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator
@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 84fa0b2 into pytorch:release/2.3 Apr 23, 2024
32 checks passed
@gs-olive gs-olive deleted the remove_implicit_batch_refs branch April 23, 2024 23:03
gs-olive added a commit that referenced this pull request Apr 23, 2024
@gs-olive
fix: Remove references to implicit batch for TRT 10 (#2773)
46cc402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@apbose apbose Awaiting requested review from apbose

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths needs-release-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @peri044 @facebook-github-bot
0