infra: Add Torch 1.13.1 testing to nightly CI #1731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gs-olive
commented
Mar 10, 2023
| @@ -96,12 +99,17 @@ def dynamo_trace( | |||
| aten_graph: bool, | |||
| tracing_mode: str = "real", | |||
| dynamo_config: Optional[DynamoConfig] = None, | |||
| ) -> Tuple[torch.fx.GraphModule, Set[Guard]]: | |||
| ) -> Tuple[torch.fx.GraphModule, Set]: | |||
There was a problem hiding this comment.
The Guard specification here was removed since this file still needs to be imported even when Torch 1.13 is used (torch_tensorrt.dump_build_info() automatically imports this). We cannot import the Guard module with Torch 1.13 since the Dynamo import is disabled on 1.13.
narendasan
reviewed
Mar 10, 2023
- Add testing for Torch 1.13.1 path in CI across both TS and FX compilation paths - Disable `aten` tests for 1.13.1, to resolve Torch Dynamo import/functionality issues - Refactor quantization FX tests to resolve key error in pattern dictionary - Add parameter fields to CI to accomodate Torch 1.13.1 version - Update `dispatch_tracer` function docstrings and imports to avoid naming issue with `torch._dynamo` vs `torchdynamo` - Rename CI versioning to use "legacy"
66cc20f to
7fa598c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
atentests for 1.13, to resolve Torch Dynamo import/functionality issuesdispatch_tracerfunction docstrings and imports to avoid naming issue withtorch._dynamovstorchdynamoSee this CI run for a sample of the 1.13.1 run results. Currently the only failing tests aretest_conv_add_standalone_modulefrom the FX quantization path, and these failures may arise from API usage changes between 1.13 and 2.0.The CI is now passing with the updates to the FX quantization path. See this CI run.
The following tests are disabled for the 1.13.1 CI workflow, due to Dynamo compatibility issues:
tracer/test_dispatch_tracer.pytracer/test_resnet.pytracer/test_resnet.pyconverters/aten_op/*Fixes #1716
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: