8000 docs: Update the documentation theme to PyTorch by narendasan · Pull Request #1063 · pytorch/TensorRT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: Update the documentation theme to PyTorch #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2022
Merged

docs: Update the documentation theme to PyTorch #1063

merged 2 commits into from
May 13, 2022

Conversation

narendasan
Copy link
Collaborator

Description

Changes the documentation theme to the PyTorch sphinx theme.

Type of change

Please delete options that are not relevant and/or add your own.

  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@narendasan
docs: Update the documentation theme to PyTorch
a1f50ae 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
@narendasan narendasan requested a review from andi4191 May 13, 2022 18:04
@github-actions github-actions bot added component: api [Python] Issues re: Python API documentation Improvements or additions to documentation labels May 13, 2022
@narendasan narendasan requested a review from ncomly-nvidia May 13, 2022 18:05
andi4191
andi4191 approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor
@andi4191 andi4191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single comment for Preview in .gitignore.
Rest LGTM

.gitignore
bazel-Torch-TensorRT-Preview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this anymore. Can we get rid of this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reaso 8000 n will be displayed to describe this comment to others. Learn more.

I dont think it hurts to keep it around just in case

docsrc/conf.py
# -- Options for HTML output -------------------------------------------------

# The theme to use for HTML and HTML Help pages. See the documentation for
# a list of builtin themes.
#
html_theme = 'sphinx_material'
html_theme = 'pytorch_sphinx_theme'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for addressing vulnerability reports?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new PyTorch theme to match the rest of the documentation

@narendasan
chore: update to new CI container
46a724c 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
@narendasan narendasan merged commit 4bbc132 into master May 13, 2022
@narendasan narendasan deleted the theme_change branch May 13, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andi4191 andi4191 andi4191 approved these changes

@ncomly-nvidia ncomly-nvidia Awaiting requested review from ncomly-nvidia

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narendasan @andi4191 @facebook-github-bot
0