8000 Deprecation: Non-int Dimmer brightness by esev · Pull Request #371 · pywemo/pywemo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deprecation: Non-int Dimmer brightness #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2023
Merged

Deprecation: Non-int Dimmer brightness #371

merged 1 commit into from
May 14, 2023

Conversation

esev
Copy link
Member
@esev esev commented May 6, 2023

Description:

Non-integer values will no longer be supported for Dimmer.set_brightness.

This was announced in the version 0.8.0 release in February 2022. https://github.com/pywemo/pywemo/releases/tag/0.8.0

Checklist:

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have read and agree to the CONTRIBUTING document.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4902844520

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 86.22%
Totals Coverage Status
Change from base Build 4887215573: 0.06%
Covered Lines: 2302
Relevant Lines: 2592
💛 - Coveralls

@esev esev merged commit ddbd32d into pywemo:main May 14, 2023
@esev esev deleted the deprecate_dimmerint branch May 14, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esev @coveralls
0