8000 Deprecation: Remove the mac address argument by esev · Pull Request #367 · pywemo/pywemo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deprecation: Remove the mac address argument #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2023
Merged

Deprecation: Remove the mac address argument #367

merged 1 commit into from
May 14, 2023

Conversation

esev
Copy link
Member
@esev esev commented May 6, 2023

Description:

The mac argument is being removed from Device.__init__ and device_from_description.

This was announced in the version 0.8.0 release in February 2022. https://github.com/pywemo/pywemo/releases/tag/0.8.0

Checklist:

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have read and agree to the CONTRIBUTING document.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4898935037

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 86.238%
Totals Coverage Status
Change from base Build 4887215573: 0.08%
Covered Lines: 2301
Relevant Lines: 2591
💛 - Coveralls

@esev esev merged commit 9eac17a into pywemo:main May 14, 2023
@esev esev deleted the deprecate_mac branch May 14, 2023 16:54
@esev esev mentioned this pull request May 14, 2023
Merged
3 tasks
This was referenced Jun 9, 2023
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
3F88 No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esev @coveralls
0