8000 Decrease the frequency of NOTIFY messages by esev · Pull Request #481 · pywemo/pywemo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Decrease the frequency of NOTIFY messages #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2023
Merged

Decrease the frequency of NOTIFY messages #481

merged 4 commits into from
Jun 27, 2023

Conversation

esev
Copy link
Member
@esev esev commented Jun 20, 2023 •
edited
Loading

Description:

Use a max-age of 1 day in both the SSDP reply and alive notification. Also decrease the frequency that the SSDP alive notifications are sent.

Logic is from https://sourceforge.net/p/pupnp/code/ci/release-1.8.0/tree/upnp/src/api/upnpapi.c#l1784

Checklist:

  • The code change is tested and works locally.
  • Tests (pytest/vcr) are added for new devices or major features.
  • There is no commented out code in this PR.
  • I have read and agree to the CONTRIBUTING document.

@esev esev added the bug label Jun 20, 2023
@coveralls
Copy link
coveralls commented Jun 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5329001795

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 93.253%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pywemo/ssdp.py 1 2 50.0%
Totals Coverage Status
Change from base Build 5300847090: 0.06%
Covered Lines: 2446
Relevant Lines: 2587
💛 - Coveralls

@esev esev merged commit 5b8a0b1 into pywemo:main Jun 27, 2023
@esev esev deleted the ssdp_max_age branch June 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esev @coveralls
0