8000 Fix missing setup.xml elements by esev · Pull Request #480 · pywemo/pywemo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix missing setup.xml elements #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2023
Merged

Fix missing setup.xml elements #480

merged 4 commits into from
Jun 27, 2023

Conversation

esev
Copy link
Member
@esev esev commented Jun 20, 2023

Description:

Make the setup.xml more closely match the values that are expected by WeMo devices.

Checklist:

  • The code change is tested and works locally.
  • Tests (pytest/vcr) are added for new devices or major features.
  • There is no commented out code in this PR.
  • I have read and agree to the CONTRIBUTING document.

@esev esev added the bug label Jun 20, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5319645618

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.191%
Totals Coverage Status
Change from base Build 5300847090: 0.0%
Covered Lines: 2444
Relevant Lines: 2586
💛 - Coveralls

@esev esev changed the title Virtual device setup.xml improvements Fix missing setup.xml elements Jun 21, 2023
@esev esev merged commit 2547bba into pywemo:main Jun 27, 2023
@esev esev deleted the setup_xml branch June 27, 2023 15:22
@esev
Copy link
Member Author
esev commented Jul 7, 2023

This made a good impact. The serial console on my dimmer shows that the pywemo virtual device is being detected now by the dimmer.

syslog: wemoApp:[2023-07-06][18:29:16.158839]<plugin_ctrlpoint.c:CtrlPointProcessDeviceDiscovery:1147> [1123:""] Allocated 14960 bytes for dev UDN: uuid:Socket-1_0-PyWemoVirtualDevice

syslog: wemoApp:[2023-07-06][18:29:18.045390]<plugin_ctrlpoint.c:subscribeDeviceServices:1097> [1123:""] Subscribed to service:urn:Belkin:service:basicevent:1, sid: uuid:b0e9bdcc-1dd1-11b2-9fb6-b5c6b84c30e0

syslog: wemoApp:[2023-07-06][18:29:18.046513]<plugin_ctrlpoint.c:CtrlPointProcessDeviceDiscovery:1158> [1123:""]  ##################### New device added:pywemo virtual device  uuid:Socket-1_0-PyWemoVirtualDevice ######################

syslog: wemoApp:[2023-07-06][18:29:18.047428]<plugin_ctrlpoint.c:CtrlPointProcessDeviceDiscovery:1159> [1123:""] DescDocURL:http://192.168.1.15:8989/setup.xml

syslog: wemoApp:[2023-07-06][18:29:18.048233]<plugin_ctrlpoint.c:CtrlPointProcessDeviceDiscovery:1160> [1123:""] FriendlyName:pywemo virtual device

syslog: wemoApp:[2023-07-06][18:29:18.049254]<plugin_ctrlpoint.c:CtrlPointProcessDeviceDiscovery:1161> [1123:""] PresURL:http://192.168.1.15:8989/pluginpres.html

syslog: wemoApp:[2023-07-06][18:29:18.050050]<plugin_ctrlpoint.c:CtrlPointProcessDeviceDiscovery:1162> [1123:""] AdvrTimeOut:86400

syslog: wemoApp:[2023-07-06][18:29:18.051643]<plugin_ctrlpoint.c:CtrlPointProcessDeviceDiscovery:1165> [1123:""] Device: uuid:Socket-1_0-PyWemoVirtualDevice updated

@esev esev mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esev @coveralls
0