8000 Validate Bridge values before assigning state by esev · Pull Request #443 · pywemo/pywemo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Validate Bridge values before assigning state #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

esev
Copy link
Member
@esev esev commented Jun 4, 2023

Description:

Check that the parameters supplied by the Bridge are correct before updating the device instance's state.

Related issue (if applicable): fixes #440

Checklist:

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have read and agree to the CONTRIBUTING document.

@esev esev added the bug label Jun 4, 2023
@coveralls
Copy link
coveralls commented Jun 4, 2023

Pull Request Test Coverage Report for Build 5167737480

  • 48 of 49 (97.96%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 93.025%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pywemo/ouimeaux_device/bridge.py 48 49 97.96%
Totals Coverage Status
Change from base Build 5165292824: 0.04%
Covered Lines: 2361
Relevant Lines: 2501

💛 - Coveralls

@esev esev merged commit e40d2d4 into pywemo:main Jun 6, 2023
@esev esev deleted the bridge branch June 6, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Bridge xml handling
2 participants
0