8000 PyWavefront 0.4.0 was only built for Python 2 · Issue #64 · pywavefront/PyWavefront · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PyWavefront 0.4.0 was only built for Python 2 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
einarf opened this issue Jul 21, 2018 · 5 comments
Closed

PyWavefront 0.4.0 was only built for Python 2 #64

einarf opened this issue Jul 21, 2018 · 5 comments

Comments

@einarf
Copy link
Member
einarf commented Jul 21, 2018 •
edited
Loading

The last release was only built for python 2 probably because it was created in a python 2 environment. It looks like you have to use the --universal flag (python setup.py bdist_wheel --universal) to create a py2 and py3 whl file.
https://wheel.readthedocs.io/en/stable/#defining-the-python-version

I don't think you need to release a new version since pypi do support uploading several distribution files for the same version. Worst case bump to 4.1.

I didn't really think about this because most projects for work and hobby have been python 3 only for the last couple of years, so setuptools built py3 only pacakges with bdist_wheel in python3 environment.
@einarf
Copy link
Member Author
einarf commented Jul 21, 2018 •
edited
Loading

Quick test (in py3 env)

Python 3 only

$ python setup.py bdist_wheel
$ ls dist/
PyWavefront-0.3.2-py3-none-any.whl

Universal

$ python setup.py bdist_wheel --universal
$ ls dist/
PyWavefront-0.3.2-py2.py3-none-any.whl

Note the py2.py3 part.

@einarf
Copy link
Member Author
einarf commented Jul 21, 2018 •
edited
Loading

Also remember to check in the version change in setup.py (can cause trouble for people running from source).

https://github.com/greenmoss/PyWavefront/blob/2656a8b2b3cf058c1a42401cafc5e17a7d23f04a/setup.py#L3

greenmoss pushed a commit that referenced this issue Jul 21, 2018
Add release steps
d624aae 
For my own edification. Relates to notes from #56 and #64.
@greenmoss
Copy link
Collaborator

I am getting forgetful about steps, so I put them all in RELEASE.md to remember. This should be good to go now, included in 0.4.1.

@einarf
Copy link
Member Author
einarf commented Jul 21, 2018

Thanks for putting up with my nagging ❤️

@greenmoss
Copy link
Collaborator

No worries, I'm happy to help support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greenmoss @einarf
0