Use Fastly to do Compression #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this will use Fastly to handle our compression rather than letting Warehouse do it.
This should reduce the amount of CPU our origin servers expend, but more importantly it means that we can do certain optimizations in Warehouse around conditional
GETrequests where we can skip executing the view if we know ahead of time that we can return a304 Not Modified. Currently this is impossible in Warehouse because the compression tween needs to read the response body to handle the ETag on compressed responses.This should roughly match the behavior of the existing compression tween, with the following differences:
This should work without code changes in Warehouse, because in
vcl_missandvcl_passwe modify the request that is going to be sent to the origin to remove theAccept-Encodingheader, so Warehouse will only see requests that accept uncompressed content.