8000 message_about_scripts_not_on_PATH: use pathlib for path normalization and resolve symlinks by lorddavidiii · Pull Request #11953 · pypa/pip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

message_about_scripts_not_on_PATH: use pathlib for path normalization and resolve symlinks #11953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

message_about_scripts_not_on_PATH: use pathlib for path normalization and resolve symlinks #11953

wants to merge 7 commits into from
+23 −21

Conversation

lorddavidiii
Copy link
Contributor

This PR is the rebased version of #11903

@lorddavidiii lorddavidiii force-pushed the norm-path-with-pathlib branch from 959c781 to cc112bf Compare April 12, 2023 10:00
@lorddavidiii lorddavidiii mentioned this pull request Apr 12, 2023
Closed
uranusjr
uranusjr reviewed Apr 12, 2023
View reviewed changes
news/11953.feature.rst Outdated
@@ -0,0 +1 @@
Migrate message_about_scripts_not_on_PATH to use pathlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should mention the slight behavioural change mentioned in the other PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I change this now

@lorddavidiii lorddavidiii changed the title message_about_scripts_not_on_PATH: use pathlib for path normalization message_about_scripts_not_on_PATH: use pathlib for path normalization and resolve symlinks Apr 12, 2023
@lorddavidiii
Copy link
Contributor Author

The failing CI job looks unrelated to this PR

@uranusjr
Copy link
Member

The new message is still not good enough to me. pip users would not have a clue what message_about_scripts_not_on_PATH means. The changelog message should focus on how the change actually affects end users, not to describe the implementation detail (that’s what the Git commit messages are for).

@ichard26 ichard26 added the state: up for grabs (PR) Good idea, but needs a new champion as the PR author is busy or unreachable. label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr left review comments

Assignees
No one assigned
Labels
bot:chronographer:provided state: up for grabs (PR) Good idea, but needs a new champion as the PR author is busy or unreachable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lorddavidiii @uranusjr @pradyunsg @ichard26
0