8000 REF: switch to CSR matrix in area binning by martinfleis · Pull Request #160 · pysal/tobler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

REF: switch to CSR matrix in area binning #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2022
Merged

REF: switch to CSR matrix in area binning #160

merged 2 commits into from
Mar 28, 2022

Conversation

martinfleis
Copy link
Member

Closes #159

  • switch to CSR
  • test both CSR and DOK
  • move weights creation behind relevant if statements so we don't compute them if they're not used

@martinfleis martinfleis requested a review from knaaptime March 28, 2022 18:29
@codecov
Copy link
codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #160 (199a8e7) into master (3f6496d) will increase coverage by 1.54%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   73.57%   75.12%   +1.54%     
==========================================
  Files          20       20              
  Lines        1003     1029      +26     
==========================================
+ Hits          738      773      +35     
+ Misses        265      256       -9
Impacted Files Coverage Δ
tobler/area_weighted/area_interpolate.py 86.30% <100.00%> (ø)
tobler/tests/test_area_interpolators.py 100.00% <100.00%> (ø)
tobler/_version.py 40.65% <0.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6496d...199a8e7. Read the comment docs.

@martinfleis martinfleis requested a review from sjsrey March 28, 2022 20:32
@knaaptime knaaptime merged commit 66f3825 into pysal:master Mar 28, 2022
@martinfleis martinfleis deleted the csr branch March 28, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knaaptime knaaptime knaaptime approved these changes

@sjsrey sjsrey Awaiting requested review from sjsrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOK sparse matrix format is a bottleneck
2 participants
@martinfleis @knaaptime
0