8000 Added additional commands to Keysight N7776C laser instrument interface. by langrock · Pull Request #1292 · pymeasure/pymeasure · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added additional commands to Keysight N7776C laser instrument interface. #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

langrock
Copy link

Updated available selection of sweep speeds, number of sweep cycles, dwell time for stepped sweeps, as well as cavity realignment and wavelength zeroing.

Copy link
codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.85%. Comparing base (952a3b4) to head (b301453).

Files with missing lines Patch % Lines
pymeasure/instruments/keysight/keysightN7776C.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1292   +/-   ##
=======================================
  Coverage   59.84%   59.85%           
=======================================
  Files         279      279           
  Lines       19397    19403    +6     
=======================================
+ Hits        11609    11613    +4     
- Misses       7788     7790    +2     
Flag Coverage Δ
unittests 59.85% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member
@BenediktBurger BenediktBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, you may add yourself to the authors.txt.

Note that docstrings should be in imperative mode (in the first line) according to python style rules.

@@ -249,6 +266,18 @@ def get_wl_data(self):
return np.array(self.adapter.connection.query_binary_values('sour0:read:data? llog',
datatype=u'd'))

def lambda_zero(self):
"""
Executes a wavelength zero.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings should be in imperative mode: Zero the wavelength.


def align_cavity(self):
"""
Optimizes the laser cavity alignment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here:

Suggested change
Optimizes the laser cavity alignment.
Optimize the laser cavity alignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0