Add Agilent B2980 electrometer series #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
+ Coverage 60.09% 60.31% +0.22%
==========================================
Files 282 283 +1
Lines 19495 19605 +110
==========================================
+ Hits 11715 11825 +110
Misses 7780 7780
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenediktBurger
requested changes
May 21, 2025
Co-authored-by: Benedikt Burger <67148916+BenediktBurger@users.noreply.github.com>
Update docstring for data buffer Co-authored-by: Benedikt Burger <67148916+BenediktBurger@users.noreply.github.com>
Rename class Battery to BatteryMixin Co-authored-by: Benedikt Burger <67148916+BenediktBurger@users.noreply.github.com>
- Channel -> Instrument for the trigger properties - Class Battery renamed to BatteryMixin, removed initialization of BatteryMixin - Add units in docstring of current and charge measurements and ranges - define explicit methods for the different trigger actions - adapt the tests to the new trigger methods - change naming from acquire to acquisition in trigger properties/methods
- adapt AgilentB2985.function to get_process_list - adapt protocol test for function = 'RES'
BenediktBurger
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the following Agilent/Keysight instruments: