Fix: pyLoad GUI #2661
Fix: pyLoad GUI #2661
Conversation
|
GUI version is not supported anymore. |
|
Is it just "not supported", or will the API/Interface be scrapped so that the GUI has no chance of working? |
|
@Burnout5151 Good Ideas, @vuolter has to answer this. API will not be removed, the WebUI and some other addons uses it. |
|
Since the new pyLoad version has a new API set, this GUI should be adapted before start working with it. |
|
|
…tle bar on windows os" This reverts commit 6661987.
…tup when the tab is selected the first time
Webserver fails to start when the internal server is started again (socket not closed)
|
Issues
======
+ Solved 15
- Added 8
Complexity increasing per file
==============================
- module/gui/Collector.py 13
- module/gui/LoggingLevels.py 2
- module/gui/Tools.py 19
- module/gui/TrayIcon.py 7
- module/gui/AboutBox.py 7
- module/gui/InfoCorePermissions.py 14
- module/gui/PackageEdit.py 1
- module/gui/AdvancedSelect.py 3
- module/gui/CaptchaDialog.py 10
- module/gui/Options.py 7
- module/gui/_pyLoadGui.py 59
- module/gui/Overview.py 1
- module/gui/SettingsWidget.py 7
- module/gui/ConnectionManager.py 1
- module/gui/Notification.py 7
- module/gui/LinkDock.py 2
Complexity decreasing per file
==============================
+ module/gui/PackageDock.py -3
+ module/gui/CoreConfigParser.py -12
Clones added
============
- module/gui/Queue.py 7
- module/gui/Collector.py 25
- module/gui/Accounts.py 1
- module/gui/Tools.py 3
- module/gui/MainWindow.py 2
- module/lib/restart_on_windows.py 1
- module/gui/PackageDock.py 8
- module/gui/Options.py 153
- module/remote/thriftbackend/Socket.py 1
- pyLoadCore.py 2
- module/gui/Connector.py 1
- module/gui/SettingsWidget.py 2
- pyLoadGui.py 10
- module/remote/thriftbackend/ThriftClient.py 2
- module/gui/ConnectionManager.py 9
- module/gui/LinkDock.py 8
Clones removed
==============
+ module/gui/CoreConfigParser.py -2
See the complete overview on Codacy |
|
|
||
| def importVersion4(): | ||
| try: | ||
| from PyQt4.Qt import PYQT_VERSION_STR |
There was a problem hiding this comment.
Codacy found an issue: Unused variable 'PYQT_VERSION_STR'
| along with this program; if not, see <http://www.gnu.org/licenses/>. | ||
| """ | ||
|
|
||
| import subprocess |
There was a problem hiding this comment.
Codacy found an issue: Consider possible security implications associated with subprocess module.
| if DESKTOP_NOTIFICATIONS is None: | ||
| # auto detect, prefer notify2 | ||
| try: | ||
| import notify2 |
There was a problem hiding this comment.
Codacy found an issue: Unused import notify2
| args.extend(sys.argv[2:]) | ||
|
|
||
| try: | ||
| subprocess.Popen(args, close_fds=True) |
There was a problem hiding this comment.
Codacy found an issue: subprocess call - check for execution of untrusted input.
| perc_sum += 100 | ||
| perc_sum += int(child.data["downloading"]["percent"]) | ||
| except: | ||
| except Exception: |
There was a problem hiding this comment.
Codacy found an issue: Try, Except, Pass detected.
| DESKTOP_NOTIFICATIONS = "notify2" | ||
| except ImportError: | ||
| try: | ||
| import pynotify |
There was a problem hiding this comment.
Codacy found an issue: Unused import pynotify
| args.append(str(os.getpid())) | ||
| args.extend(sys.argv) | ||
| try: | ||
| subprocess.Popen(args, close_fds=True) |
There was a problem hiding this comment.
Codacy found an issue: subprocess call - check for execution of untrusted input.
|
|
||
| def importVersion5(): | ||
| try: | ||
| from PyQt5.Qt import PYQT_VERSION_STR |
There was a problem hiding this comment.
Codacy found an issue: Unused variable 'PYQT_VERSION_STR'
Readme: https://github.com/snilt/pyload/tree/forkreadme