8000 Relax intensity of error for `issubclass` and `isinstance` schemas from json by sydney-runkle · Pull Request #1479 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Relax intensity of error for issubclass and isinstance schemas from json #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2024
Merged

Relax intensity of error for issubclass and isinstance schemas from json #1479

merged 4 commits into from
Oct 10, 2024

Conversation

sydney-runkle
Copy link
Contributor

Closes pydantic/pydantic#8890

Makes these more compatible with validation in unions.

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Oct 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1479 will not alter performance

Comparing lax-internal-errs (68f000d) with main (dc4846e)

Summary

✅ 155 untouched benchmarks

davidhewitt
davidhewitt reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor
@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall motivation of the change looks good, though I wonder about an alternative naming?

davidhewitt
davidhewitt approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor
@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sydney-runkle sydney-runkle merged commit b773c9d into main Oct 10, 2024
28 of 29 checks passed
@sydney-runkle sydney-runkle deleted the lax-internal-errs branch October 10, 2024 13:02
@UlfurOrn UlfurOrn mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NotImplementedError: Cannot check isinstance when validating from json, use a JsonOrPython validator instead.
2 participants
@sydney-runkle @davidhewitt
0