8000 Make round trip exclude computed fields by dmontagu · Pull Request #934 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make round trip exclude computed fields #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

Make round trip exclude computed fields #934

merged 1 commit into from
Aug 28, 2023

Conversation

dmontagu
Copy link
Collaborator
@dmontagu dmontagu commented Aug 28, 2023 •
edited by pydantic-hooky bot
Loading

Closes pydantic/pydantic#7158

Selected Reviewer: @adriangb

@dmontagu dmontagu force-pushed the dmontagu/round-trip-computed-fields branch from 855273a to cb6b697 Compare August 28, 2023 17:14
@dmontagu
Copy link
Collaborator Author

please review

@codecov
Copy link
codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #934 (cb6b697) into main (7f7d03d) will increase coverage by 0.04%.
Report is 11 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
+ Coverage   93.78%   93.82%   +0.04%     
==========================================
  Files         105      105              
  Lines       15331    15442     +111     
  Branches       25       25              
==========================================
+ Hits        14378    14489     +111     
  Misses        947      947              
  Partials        6        6
Files Changed Coverage Δ
src/serializers/computed_fields.rs 96.06% <100.00%> (+0.19%) ⬆️

... and 15 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7d03d...cb6b697. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented Aug 28, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #934 will degrade performances by 25.42%

Comparing dmontagu/round-trip-computed-fields (cb6b697) with main (34fbd84)

Summary

❌ 2 regressions
✅ 136 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dmontagu/round-trip-computed-fields Change
❌ test_dont_raise_error 29.3 µs 39.2 µs -25.42%
❌ test_decimal_from_string_core 54 µs 71 µs -23.97%

@dmontagu dmontagu merged commit b9f45f9 into main Aug 28, 2023
@dmontagu dmontagu deleted the dmontagu/round-trip-computed-fields branch August 28, 2023 18:03
@liu-junyong liu-junyong mentioned this pull request Sep 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@adriangb adriangb

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should round_trip=True ignore @computed_field ?
2 participants
@dmontagu @adriangb
0