8000 Fix `pytest tests/benchmarks --benchmark-enable` by dmontagu · Pull Request #912 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix pytest tests/benchmarks --benchmark-enable #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix pytest tests/benchmarks --benchmark-enable #912

merged 1 commit into from
Aug 21, 2023

Conversation

dmontagu
Copy link
Collaborator

No description provided.

@dmontagu dmontagu changed the title Fix pytest tests/benchmarks --benchmark-enable Fix pytest tests/benchmarks --benchmark-enable Aug 21, 2023
@codspeed-hq
Copy link
codspeed-hq bot commented Aug 21, 2023

CodSpeed Performance Report

Merging #912 will not alter performance

Comparing dmontagu/fix-benchmark-running (85d8c1c) with main (8bf9e5f)

Summary

✅ 138 untouched benchmarks

adriangb
adriangb approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member
@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the problem was but this seems like a simple change

@dmontagu
Copy link
Collaborator Author

Without this it tries to sort by the name and the name can be none. I think we should fix that issue in the pytest-speed library but anyway this makes it work locally. Ran into this while running all benchmarks for the sake of testing perf of the tuple refactor

@dmontagu dmontagu merged commit 7f7d03d into main Aug 21, 2023
@dmontagu dmontagu deleted the dmontagu/fix-benchmark-running branch August 21, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmontagu @adriangb
0