8000 fix warning from scipy backend guess_can_open on directory by germasch · Pull Request #9911 · pydata/xarray · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix warning from scipy backend guess_can_open on directory #9911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2025
Merged

fix warning from scipy backend guess_can_open on directory #9911

merged 1 commit into from
Jan 1, 2025

Conversation

germasch
Copy link
Contributor

When passing a directory to open_dataset(), the scipy backend fails and a "RuntimeWarning: 'scipy' fails while guessing" is produced.

This affects me since I'm implementing a backend to read data written by the adios2 package, whose data "files" are actually a directory.

This tiny patch treats this case just like file not found, that is, the scipy backend will now return that it cannot open such a "file", but without raising an exception.

@welcome Welcome
Copy link
welcome bot commented Dec 19, 2024

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

headtr1ck
headtr1ck approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator
@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a useful addition, thanks!
Should we maybe catch a PermissionError as well?

And feel free to add an entry in whats-new.

@germasch
fix warning from scipy backend guess_can_open on directory
133e3dd 
When passing a directory to open_dataset(), the scipy backend fails
and a "RuntimeWarning: 'scipy' fails while guessing" is produced.

This affects me since I'm implementing a backend to read data written
by the adios2 package, whose data "files" are actually a directory.

This tiny patch treats this case just like file not found, that is, the
scipy backend will now return that it cannot open such a "file", but
without raising an exception.
@germasch germasch force-pushed the pr/backend-scipy-not-a-directory branch from 4505e6f to 133e3dd Compare December 25, 2024 15:05
@germasch
Copy link
Contributor Author

I figured this change is too minor to justify a whats-new entry, but I'd be happy to do so if you'd like.

Good point about considering PermissionError, too. I just looked, and PermissionError is already special cased in the case of built-in backends, in that it's re-raised. I think that's the right thing to do -- a PermissionError is very likely not happening because it's a mismatched backend, but rather because of an actual permission problem, and the user will benefit from the specific failure (exception), as opposed to a generic "no matching backend found" error. So I think the answer is probably to propagate a PermissionError from plugin backends to the user as well. If you agree, I can make that change, and make sure that it behaves as desired.

@headtr1ck
Copy link
Collaborator

You are right, a PermissionError should be raised normally here.

You can still add an entry in what's new if you like.

@headtr1ck headtr1ck added the plan to merge Final call for comments label Dec 29, 2024
headtr1ck

This comment was marked as outdated.

Sign in to view

@headtr1ck headtr1ck merged commit dc03b80 into pydata:main Jan 1, 2025
35 checks passed
@welcome Welcome
Copy link
welcome bot commented Jan 1, 2025

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! celebration gif

@headtr1ck
Copy link
Collaborator

Thanks!

dcherian added a commit to dcherian/xarray that referenced this pull request Mar 19, 2025
@dcherian
Merge branch 'main' into custom-groupers
9f3c270 
* main: (63 commits)
  Fix zarr upstream tests (pydata#9927)
  Update pre-commit hooks (pydata#9925)
  split out CFDatetimeCoder, deprecate use_cftime as kwarg (pydata#9901)
  dev whats-new (pydata#9923)
  Whats-new 2025.01.0 (pydata#9919)
  Silence upstream Zarr warnings (pydata#9920)
  time coding refactor (pydata#9906)
  fix warning from scipy backend guess_can_open on directory (pydata#9911)
  Enhance and move ISO-8601 parser to coding.times (pydata#9899)
  Edit serialization error message (pydata#9916)
  friendlier error messages for missing chunk managers (pydata#9676)
  Bump codecov/codecov-action from 5.1.1 to 5.1.2 in the actions group (pydata#9915)
  Rewrite interp to use `apply_ufunc` (pydata#9881)
  Skip dask rolling (pydata#9909)
  Explicitly configure ReadTheDocs build to use conf.py (pydata#9908)
  Cache pre-existing Zarr arrays in Zarr backend (pydata#9861)
  Optimize idxmin, idxmax with dask (pydata#9800)
  remove unused "type: ignore" comments in test_plot.py (fixed in matplotlib 3.10.0) (pydata#9904)
  move scalar-handling logic into `possibly_convert_objects` (pydata#9900)
  Add missing DataTree attributes to docs (pydata#9876)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headtr1ck headtr1ck headtr1ck approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments topic-backends
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germasch @headtr1ck
0