Fix "all numeric" quoting behavior #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `re_all_numeric` che 8000 ck used to allow any number of decimal points in the value, which isn't correct for numerics; at most one can be allowed. Rename to `re_numeric`, and use a more complex RE that allows a maximum of one decimal point, but fails on strings like "1.4.0". Fixes pydot#438
|
It might make sense to backport this onto the v3.0.2 branch, and release a v3.0.3 with this fix, since I don't know that 4.0 is ready to go out the door yet. LMK if you'd like me to put together another PR for that. (Edit: Actually, it might be better if you first create a |
e45d3ee to
df1df8b
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
df1df8b to
9d936c0
Compare
|
The |
Merged
lkk7
pushed a commit
that referenced
this pull request
Nov 28, 2024
* Fix numeric-value regular expression The `re_all_numeric` check used to allow any number of decimal points in the value, which isn't correct for numerics; at most one can be allowed. Rename to `re_numeric`, and use a more complex RE that allows a maximum of one decimal point, but fails on strings like "1.4.0". Fixes #438 * Add tests for re_numeric quoting behavior
|
Thanks, I'll try to release v3.0.3 tomorrow or this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
re_all_numericcheck used to allow any number of decimal points in the value, which isn't correct for numerics; at most one can be allowed. Rename tore_numeric, and use a more complex RE that allows a maximum of one decimal point, but fails on strings like "1.4.0".Fixes #438
A new unit test confirms the correct behavior for numeric strings with varying numbers of decimal points.