8000 Use 'standard' file extensions for dag and sub files · Issue #134 · pycondor/pycondor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use 'standard' file extensions for dag and sub files #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
duncanmmacleod opened this issue Feb 21, 2019 · 2 comments · May be fixed by #139
Open

Use 'standard' file extensions for dag and sub files #134

duncanmmacleod opened this issue Feb 21, 2019 · 2 comments · May be fixed by #139
Labels
enhancement

Comments

@duncanmmacleod
Copy link
Member

Description

Currently, pycondor writes all submission files using the .submit file extension. I think it would be good to instead write dagman files with .dag and job files with .sub, as seems to be the standard usage (according to the condor manual, and my personal experience).

This is a pretty simple change, so am happy to implement it and submit a PR, but wanted to check whether this is not done currently for a good reason, or whether there are any gotchas.
@jrbourbeau
Copy link
Member

Thanks for bringing this up @duncanmmacleod! The current use of .submit for both job and dagman files is arbitrary, it's what I've used in my personal projects. I think that distinguishing between the two file types would be useful. Standardizing to .sub and .dag from the condor user manual seems reasonable to me.

A PR would be very welcome :) I suspect this should be a relatively straightforward update. There are probably some places in the documentation or perhaps a few tests that make reference to the current .submit extension which will need to be updated.

duncanmmacleod added a commit to duncanmmacleod/pycondor that referenced this issue Apr 4, 2019
@duncanmmacleod
pycondor: use 'standard' file extensions
4f5bbc2 
- use `.dag` for dag files
- use `.sub` for submit files

Fixes pycondor#134
@duncanmmacleod duncanmmacleod linked a pull request Apr 4, 2019 that will close this issue
Open
duncanmmacleod added a commit to duncanmmacleod/pycondor that referenced this issue Jun 24, 2022
@duncanmmacleod
pycondor: use 'standard' file extensions
a0f8daa 
- use `.dag` for dag files
- use `.sub` for submit files

Fixes pycondor#134
8325
duncanmmacleod added a commit to duncanmmacleod/pycondor that referenced this issue Jul 8, 2022
@duncanmmacleod
pycondor: use 'standard' file extensions
fd71b4e 
- use `.dag` for dag files
- use `.sub` for submit files

Fixes pycondor#134
@eagoetz
Copy link
eagoetz commented Dec 18, 2023

Just came across this issue myself and want to lend my support to this change. It makes much more sense from a user perspective for the dag and submit files to have different extensions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use 'standard' file extensions for output files duncanmmacleod/pycondor
3 participants
@duncanmmacleod @jrbourbeau @eagoetz
0