8000 Fix occasional deadlocks when doing multiple similar syncs concurrently. by ggainey · Pull Request #1637 · pulp/pulpcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ pulpcore Public

Fix occasional deadlocks when doing multiple similar syncs concurrently. #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2021
Merged

Fix occasional deadlocks when doing multiple similar syncs concurrently. #1637

merged 1 commit into from
Sep 28, 2021

Conversation

ggainey
Copy link
Contributor
@ggainey ggainey commented Sep 21, 2021

Forcing deadlocks requires a lot of time and pulpcore-workers running.
There is therefore no specific CI test for this, but there is a reproducer
script that will force deadlocks to happen (and show that they're fixed) here:

https://github.com/ggainey/pulp_startup/blob/main/8750_deadlocks/file_repro.sh

fixes #8750.
[nocoverage]

Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html

@pulpbot
Copy link
Member
pulpbot commented Sep 21, 2021

Attached issue: https://pulp.plan.io/issues/8750

mdellweg
mdellweg approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member
@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit pick for style.

So glad, the stages never promised to retain the order of d_content passed along.

@ggainey
Fix occasional deadlocks when doing multiple similar syncs concurrently.
7706859 
Forcing deadlocks requires a lot of time and pulpcore-workers running.
There is therefore no specific CI test for this, but there is a reproducer
script that will force deadlocks to happen (and show that they're fixed) here:

https://github.com/ggainey/pulp_startup/blob/main/8750_deadlocks/file_repro.sh

fixes #8750.
[nocoverage]
@ggainey ggainey changed the title Fix occasional deadlocks when doing multiple similar syncs concurrently. DRAFT: Fix occasional deadlocks when doing multiple similar syncs concurrently. Sep 23, 2021
@ggainey ggainey changed the title DRAFT: Fix occasional deadlocks when doing multiple similar syncs concurrently. Fix occasional deadlocks when doing multiple similar syncs concurrently. Sep 23, 2021
ggainey added a commit to ggainey/pulpcore that referenced this pull request Sep 23, 2021
@ggainey
Teach several touch() paths to apply order to avoid deadlocks.
c151752 
fixes #9441.
[nocoverage]
Required PR: pulp#1637
ggainey added a commit to ggainey/pulpcore that referenced this pull request Sep 24, 2021
@ggainey
Teach several touch() paths to apply order to avoid deadlocks.
6276470 
fixes #9441.
[nocoverage]
Required PR: pulp#1637
@ggainey ggainey mentioned this pull request Sep 24, 2021
Merged
ggainey added a commit to ggainey/pulpcore that referenced this pull request Sep 24, 2021
@ggainey
Teach several touch() paths to apply order to avoid deadlocks.
8fbc958 
fixes #9441.
[nocoverage]
Required PR: pulp#1637
@dkliban dkliban self-requested a review September 28, 2021 13:48
ggainey added a commit to ggainey/pulpcore that referenced this pull request Sep 28, 2021
@ggainey
Teach the touch() path to apply order to avoid deadlocks.
2a125fb 
fixes #9441.
[nocoverage]
Required PR: pulp#1637
dralley pushed a commit that referenced this pull request Sep 28, 2021
@ggainey @dralley
Teach the touch() path to apply order to avoid deadlocks.
cd9b578 
fixes #9441.
[nocoverage]
Required PR: #1637
dralley added a commit to dralley/pulpcore that referenced this pull request Sep 28, 2021
@dralley
Teach the touch() path to apply order to avoid deadlocks.
a225077 
backports #9441.
[nocoverage]
Required PR: pulp#1637

fixes #9445

(cherry picked from commit cd9b578)
@dralley dralley merged commit 6af3519 into pulp:master Sep 28, 2021
ggainey added a commit to ggainey/pulpcore that referenced this pull request Sep 28, 2021
@ggainey
Teach several touch() paths to apply order to avoid deadlocks.
faeb2e7 
fixes #9441.
[nocoverage]
Required PR: pulp#1637
dralley added a commit that referenced this pull request Sep 29, 2021
@dralley
Teach the touch() path to apply order to avoid deadlocks.
69b2e1d 
backports #9441.
[nocoverage]
Required PR: #1637

fixes #9445

(cherry picked from commit cd9b578)
@ggainey ggainey deleted the 8750_deadlocks branch May 10, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddavis daviddavis daviddavis left review comments

@dralley dralley dralley left review comments

@dkliban dkliban dkliban approved these changes

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ggainey @pulpbot @daviddavis @dkliban @dralley @mdellweg
0