8000 logText checks if its argument is an empty string before printing by mardukbp · Pull Request #521 · p6spy/p6spy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

logText checks if its argument is an empty string before printing #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2021
Merged

logText checks if its argument is an empty string before printing #521

merged 2 commits into from
Mar 5, 2021

Conversation

mardukbp
Copy link
Contributor

This PR solves #513.

@mardukbp mardukbp mentioned this pull request Jan 29, 2021
Open
@typekpb
Copy link
Member
typekpb commented Jan 30, 2021

@mardukbp thanks for the contribution, please provide junit test as well.

@mardukbp
Copy link
Contributor Author
mardukbp commented Jan 31, 2021 •
edited
Loading

@typekpb I just added a test for the Log4JLogger. I noticed that many tests use the P6TestLogger, which overrides the logText method of the StdoutLogger. This is precisely the method affected by my commit. The P6TestLogger has a logs array and what I have seen is that many tests do something and then call the getLastEntry method, which returns the last entry of the logs array. But this does not work for testing my modification to logText.

How do you suggest that I test StdoutLogger.logText?

@typekpb
Copy link
Member
typekpb commented Mar 5, 2021

@mardukbp we have currently no tests for the class, I guess you did your job, thanks for the contribution, merging

@typekpb typekpb merged commit e3929df into p6spy:master Mar 5, 2021
@typekpb typekpb mentioned this pull request Mar 5, 2021
Closed
@mardukbp mardukbp deleted the check-empty-string branch March 28, 2021 21:43
bingoohuang added a commit to bingoohuang/p6spy that referenced this pull request Jul 28, 2022
@bingoohuang
logText checks if its argument is an empty string before printing (p6…
1ed8c82 
…spy#521) e3929df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mardukbp @typekpb
0