-
Notifications
You must be signed in to change notification settings - Fork 466
[BMv2] PNA: hash default + enum fix #5196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If you name it [BMv2] it should autotag the PR. A feature a student recently implemented. |
@Vineet1101 Could you check the failure in the tagging? It doesn't seem to work? |
@fruffy ya sure will look into this |
@fruffy It is currently failing with a Resource not accessible by integration error because the GitHub Actions runner doesn't have permission to add labels. Could you please go to Settings → Actions → General in the repo, scroll down to Workflow permissions, and enable "Read and write permissions" for GITHUB_TOKEN? This will allow the workflow to add labels as intended. If you do not want the actions to give access to read and write you can copy the file and add it yourself in the main branch |
|
Signed-off-by: Glen Gibb <gleng@ai-fabrics.com>
Signed-off-by: Glen Gibb <gleng@ai-fabrics.com>
PNA_Direction_t is used in pna_pre_input_metadata_t in the top-level (p4include) pna.p4 file. This needs to be mapped to an bit<32> for compilation to proceed. Signed-off-by: Glen Gibb <gleng@ai- B166 fabrics.com>
Signed-off-by: Glen Gibb <gleng@ai-fabrics.com>
BMv2 PNA fixes:
PNA_Direction_t
to a 32b value. (PNA_Direction_t
is defined in p4include/pna.p4 but not p4include/bmv2/pna.p4)Enable some PNA tests in ctest
Note: There are currently multiple versions of pna.p4 that differ from one another (p4include/pna.p4, p4include/bmv2/pna.p4, p4include/tc/pna.p4 and p4include/dpdk/pna.p4). This PR attempts to provide some base-level compatibility with the p4include/pna.p4 file.