8000 [BMv2] PNA: hash default + enum fix by grg · Pull Request #5196 · p4lang/p4c · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BMv2] PNA: hash default + enum fix #5196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025
Merged

Conversation

grg
Copy link
Contributor
@grg grg commented Mar 25, 2025

BMv2 PNA fixes:

  • Convert PNA_Direction_t to a 32b value. (PNA_Direction_t is defined in p4include/pna.p4 but not p4include/bmv2/pna.p4)
  • Convert TARGET_DEFAULT to CRC16 for the hash algorithm.

Enable some PNA tests in ctest

Note: There are currently multiple versions of pna.p4 that differ from one another (p4include/pna.p4, p4include/bmv2/pna.p4, p4include/tc/pna.p4 and p4include/dpdk/pna.p4). This PR attempts to provide some base-level compatibility with the p4include/pna.p4 file.

@grg grg marked this pull request as ready for review March 25, 2025 18:58
@grg grg requested a review from fruffy March 25, 2025 18:58
@fruffy
Copy link
Collaborator
fruffy commented Mar 26, 2025

If you name it [BMv2] it should autotag the PR. A feature a student recently implemented.

@fruffy fruffy changed the title BMv2: PNA: hash default + enum fix [BMv2] PNA: hash default + enum fix Mar 26, 2025
@fruffy
Copy link
Collaborator
fruffy commented Mar 26, 2025

@Vineet1101 Could you check the failure in the tagging? It doesn't seem to work?

@Vineet1101
Copy link
Contributor

@fruffy ya sure will look into this

@Vineet1101
Copy link
Contributor
Vineet1101 com 8000 mented Mar 26, 2025

@fruffy It is currently failing with a Resource not accessible by integration error because the GitHub Actions runner doesn't have permission to add labels.

Could you please go to Settings → Actions → General in the repo, scroll down to Workflow permissions, and enable "Read and write permissions" for GITHUB_TOKEN?

This will allow the workflow to add labels as intended. If you do not want the actions to give access to read and write you can copy the file and add it yourself in the main branch

@fruffy
Copy link
Collaborator
fruffy commented Mar 26, 2025

@fruffy It is currently failing with a Resource not accessible by integration error because the GitHub Actions runner doesn't have permission to add labels.

Could you please go to Settings → Actions → General in the repo, scroll down to Workflow permissions, and enable "Read and write permissions" for GITHUB_TOKEN?

This will allow the workflow to add labels as intended. If you do not want the actions to give access to read and write you can copy the file and add it yourself in the main branch

image
This already seems enabled. Fixed in #5197.

grg added 4 commits March 26, 2025 05:53
Signed-off-by: Glen Gibb <gleng@ai-fabrics.com>
Signed-off-by: Glen Gibb <gleng@ai-fabrics.com>
PNA_Direction_t is used in pna_pre_input_metadata_t in the top-level
(p4include) pna.p4 file. This needs to be mapped to an bit<32> for
compilation to proceed.

Signed-off-by: Glen Gibb <gleng@ai-
B166
fabrics.com>
Signed-off-by: Glen Gibb <gleng@ai-fabrics.com>
@grg grg force-pushed the gleng/pna-support branch from 325e846 to de75d69 Compare March 26, 2025 12:53
@grg grg enabled auto-merge March 26, 2025 12:53
@fruffy fruffy added the bmv2 Topics related to BMv2 or v1model label Mar 26, 2025
@grg grg added this pull request to the merge queue Mar 26, 2025
Merged via the queue into p4lang:main with commit 2428668 Mar 26, 2025
21 checks passed
@grg grg deleted the gleng/pna-support branch March 26, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bmv2 Topics related to BMv2 or v1model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0