8000 Add typed version of `isInContext()` and make use of it instead of `findContext()` by asl · Pull Request #5048 · p4lang/p4c · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add typed version of isInContext() and make use of it instead of findContext() #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2024
Merged

Add typed version of isInContext() and make use of it instead of findContext() #5048

merged 2 commits into from
Dec 3, 2024

Conversation

asl
Copy link
Contributor
@asl asl commented Dec 3, 2024

No description provided.

asl added 2 commits December 3, 2024 09:38
@asl
Add typed version of isInContext
79940e7 
Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
@asl
Make use of typed version of isInContext() instead of findContext()
a2ae043 
Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
@asl asl requested review from vlstill and fruffy December 3, 2024 17:39
@asl
Copy link
Contributor Author
asl commented Dec 3, 2024

As return value of findContext is not needed we can skip the dyncast and just do a quick typeid check.

@asl asl added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Dec 3, 2024
@asl asl enabled auto-merge December 3, 2024 18:08
@asl asl added this pull request to the merge queue Dec 3, 2024
Merged via the queue into p4lang:main with commit 7f45ec8 Dec 3, 2024
20 checks passed
@asl asl deleted the in_context branch December 3, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruffy fruffy fruffy approved these changes

@vlstill vlstill Awaiting requested review from vlstill

Assignees
No one assigned
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asl @fruffy
0