This repository was archived by the owner on Aug 25, 2024. It is now read-only.
Logux::Rack integration #75
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant definitions from the Logux module - Remove ActiveSupport::Autoload module from Logux, since all core modules were autoloaded with Kernel#autoload, and an explicit load path is used anyway
It makes sense to move root module to lib/logux/rails.rb after the gem is renamed to logux-rails. Gems naming convention: https://guides.rubygems.org/name-your-gem/
- The .rake module is the part of the Rails engine. It will be autoloaded. - This update redefines default paths to match typical Rails application structure.
This update makes sure ActionCaller override is loaded: it was not possible to use autoload for lib/logux/action_caller.rb here, since the original ActionCaller implementation was already autoloaded in the logux-rack gem, and the autoload would not not trigger.
Rake tasks are moved to the logux-rack gem, and not depend on the Rails environment any longer.
|
@dsalahutdinov Take a look, pls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch replicates my logux_rails update with some post-merge fixes. It reduces gem responsibility scope to Rails-specific features after core Logux back-end server functionality was moved to
logux-rack.Project updates
logux-rack.logux-rackis aded to thelogux_railsdependencies.Logux::Model::UpdatesDeprecatoris coupled withLogux::ActionCaller(fromlogux-rackgem) via Logux configuration.Further improvements
It makes sense to rename the gem to
logux-railsand useLogux::Railsas the primary namespace to follow RubyGems naming convention and avoid potential definition collisions. At the momentlogux_railsandlogux-rackboth has constant definitions in the commonLoguxmodule.I'm not aware if supporting alternative ORMs is relevant, but for now
Logux::Modelis kept withinlogux_rails(since it is designed forActiveRecord). To make Logux framework ORM-agnostic, it is possible to extract model abstraction intologux-modelgem, and then introduce a set of adapters to the Logux gems family (logux-model-active_record,logux-model-sequel, etc). This worth a separate PR, though.References
logux-rackgem: https://github.com/dreikanter/logux-rack/pull/2