This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Fix memory leaks in FFmpegController, iina#1720 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `getPeeksForFile` in `FFmpegController` is leaking memory when generating thumbnails. This commit will: - Add a `@try-@finally` block in the while loop to free the packet - Replace `av_free` by `av_frame_free`, when freeing an `AVFrame` - Add a call to `sws_freeContext` to free the `SwsContext` - Replace deprecated method `avcodec_close` with `avcodec_free_context` - Add `nullable` annotation to declaration of `probeVideoInfoForFile` This is a stopgap fix and does not address all of the potential leaks in the method. This commit focuses on the leaks that occur during the normal flow when generating thumbnails. Error flows will still leak memory. At some point this method should be refactored to always properly free memory.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
getPeeksForFileinFFmpegControlleris leaking memorywhen generating thumbnails. This commit will:
Add a
@try-@finallyblock in the while loop to free the packetReplace
av_freebyav_frame_free, when freeing anAVFrameAdd a call to
sws_freeContextto free theSwsContextReplace deprecated method
avcodec_closewithavcodec_free_contextAdd
nullableannotation to declaration ofprobeVideoInfoForFileThis is a stopgap fix and does not address all of the potential leaks
in the method. This commit focuses on the leaks that occur during the
normal flow when generating thumbnails. Error flows will still leak
memory. At some point this method should be refactored to always
properly free memory.
Description: