8000 Fix default timezone as parsed by date_recur on initial submission. Fixes #184 by ekes · Pull Request #185 · localgovdrupal/localgov_events · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix default timezone as parsed by date_recur on initial submission. Fixes #184 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

Fix default timezone as parsed by date_recur on initial submission. Fixes #184 #185

merged 2 commits into from
Mar 25, 2025

Conversation

ekes
Copy link
Member
@ekes ekes commented Mar 24, 2025

Add the required default_time_zone_source key to our default configuration.
Update existing configuration adding the key, if it does not already exist (safe for existing sites that have updated their config, safe for runing on dev exporting config and importing into prod where the update will run again).

Fixes #184 by ensuring the default timezone is passed into the validation of the date_recur field from the get-go (like when Entity Browser causes an early for rebuild).

@ekes ekes requested review from finnlewis and graham-web March 24, 2025 12:45
@finnlewis
Copy link
Member

Testing

@finnlewis
Copy link
Member

@ekes any idea why it reports the following for 8003 and not the other update hooks?

Run cd html
 0/5 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%
 5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] [10](https://github.com/localgovdrupal/localgov_events/actions/runs/14035598656/job/39292878555?pr=185#step:5:11)0%

Error: Function localgov_events_update_8003() has no return type specified.
 ------ ---------------------------------------------------------------------- 
  Line   localgov_events.install                                               
 ------ ---------------------------------------------------------------------- 
  83     Function localgov_events_update_8003() has no return type specified.  
 ------ ----------------------------------------------------------------------

@finnlewis
Copy link
Member

Changing it to

function localgov_events_update_8003(): void {

Gets rid of the error. Is that the "right" thing to do?

@finnlewis finnlewis merged commit 03e594f into 3.x Mar 25, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnlewis finnlewis finnlewis approved these changes

@graham-web graham-web Awaiting requested review from graham-web

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown or bad timezone () in DateTimeZone->__construct() (line 25 of contrib/date_recur/src/Plugin/Field/DateRecurDateTimeComputed.php).
2 participants
@ekes @finnlewis
0